Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added convertCompressed for visionOS 2.0 #2926

Merged
merged 3 commits into from
Oct 19, 2024

Conversation

Matt54
Copy link
Member

@Matt54 Matt54 commented Aug 11, 2024

Hides existing convertCompressed from visionOS since it does not compile on the platform and adds a modern concurrency version of convertCompressed which works with visionOS 2.0

Related:
#2921
#2923

@Matt54 Matt54 requested review from aure and wtholliday as code owners August 11, 2024 03:32
@Matt54 Matt54 self-assigned this Aug 11, 2024
@warpling
Copy link
Member

Would love to see this merged before 2.0 releases if possible! Thanks @Matt54 and @aure!

@aure
Copy link
Member

aure commented Aug 20, 2024

Would love to see this merged before 2.0 releases if possible! Thanks @Matt54 and @aure!

Converter/FormatConverter+Compressed.swift:86:33: error: argument passed to call that takes no arguments
try await session.export(to: outputURL, as: outputFileType)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

on iOS. @Matt54

@Matt54
Copy link
Member Author

Matt54 commented Aug 20, 2024

Would love to see this merged before 2.0 releases if possible! Thanks @Matt54 and @aure!

Converter/FormatConverter+Compressed.swift:86:33: error: argument passed to call that takes no arguments try await session.export(to: outputURL, as: outputFileType) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

on iOS. @Matt54

Ahhhh of coarse! It doesn't compile if you're not on Xcode 16. Let me see what I can do

@warpling
Copy link
Member

Nice! I could not figure out what was going on 🙈

@Matt54
Copy link
Member Author

Matt54 commented Aug 20, 2024

I've made it compile by Swift checking it against 6.0 @aure

@Matt54
Copy link
Member Author

Matt54 commented Aug 20, 2024

Which actually isn't an ideal solution.. AudioKit is pinned to 5.9 so that code just never compiles now

@Matt54
Copy link
Member Author

Matt54 commented Aug 20, 2024

I guess our options here are to either delete the new convertCompressed method or leave it to become available once AudioKit hits Swift 6.0

I don't care either way - seems inconsequential. We're just trying to fix visionOS

@aure aure merged commit 73098f1 into AudioKit:main Oct 19, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants