Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The parameter expects a Community type when it actually uses an int t… #26

Merged
merged 2 commits into from
Apr 10, 2021
Merged

The parameter expects a Community type when it actually uses an int t… #26

merged 2 commits into from
Apr 10, 2021

Conversation

extremq
Copy link
Contributor

@extremq extremq commented Apr 9, 2021

…ype.

IDE RAISES ERRORS BECAUSE OF THIS 😡😡😡

@extremq
The parameter expects a Community type when it actually uses an int t…
4e90781 
…ype.

IDE RAISES ERRORS BECAUSE OF THIS 😡😡😡
@Athesdrake
Copy link
Owner

It accepts both the type int and the enumeration Community. Therefore, the type should be an union of both: Union[Community, int].
I'll merge once you fix this.

@extremq
Copy link
Contributor Author

extremq commented Apr 10, 2021

Done!! :)

@extremq
Copy link
Contributor Author

extremq commented Apr 10, 2021

And by the way, incredible library!!

@Athesdrake
Copy link
Owner

And by the way, incredible library!!

It's thanks to people like you that helps me improving it!

@Athesdrake Athesdrake merged commit 6da6d91 into Athesdrake:master Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@extremq @Athesdrake