Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Remove checking author in PRs #2003

Merged
merged 2 commits into from
Jul 24, 2021
Merged

chore(ci): Remove checking author in PRs #2003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33cef39
remove checking author in PRs
MaxGraey Jul 24, 2021
6e64038
Update .github/PULL_REQUEST_TEMPLATE.md
MaxGraey Jul 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@
⯈
⯈

- [ ] I've read the contributing guidelines
- [ ] I've read the contributing guidelines
- [ ] I've added my name and email to the NOTICE file
14 changes: 0 additions & 14 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1.0.0
- name: "Check that author is present in the NOTICE file"
if: github.event_name == 'pull_request'
run: |
AUTHOR=$(git log -1 --format="%aE")
if [ -z "$AUTHOR" ]; then
printf "\Cannot perform NOTICE check: Commit does not include an email address.\n" &&
exit 1;
elif ! grep -q "$AUTHOR" NOTICE || false; then
printf "\nAuthor '$AUTHOR' does not appear to be listed in the NOTICE file, yet.\n" &&
printf "Please see https://github.com/AssemblyScript/assemblyscript/blob/main/CONTRIBUTING.md\n" &&
exit 1;
else
printf "\nOK: Author is present in the NOTICE file.\n";
fi
- name: "Check that distribution files are unmodified"
if: github.event_name == 'pull_request'
run: |
Expand Down