Fix: spike when tone portamento is used without a target note. Thanks @…

…DanielOaks for pinpointing the issue.
Artefact2 · Jan 8, 2015 · 467d312 · 467d312
1 parent 69a5e8a
commit 467d312
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -140,7 +140,7 @@ tremor.xm     | PASS           | MilkyTracker           | Should sound identical
 amiga.xm      | FAIL           | MilkyTracker, xmp      | Should sound identical.
 pattern-lo….xm| PASS           | MilkyTracker           | Should play the same notes at the same time.
 finetune.xm   | PASS           | MilkyTracker           | Left and right channels should sound identical.
-tone-porta….xm| FAIL           | MilkyTracker           | Should sound identical.
+tone-porta….xm| PASS           | MilkyTracker           | Should sound identical.
 ~~~
 
 Thanks

diff --git a/src/play.c b/src/play.c
@@ -202,6 +202,10 @@ static void xm_arpeggio(xm_context_t* ctx, xm_channel_context_t* ch, uint8_t par
 }
 
 static void xm_tone_portamento(xm_context_t* ctx, xm_channel_context_t* ch) {
+	/* 3xx called without a note, wait until we get an actual
+	 * target note. */
+	if(ch->tone_portamento_target_period == 0.f) return;
+
 	if(ch->period != ch->tone_portamento_target_period) {
 		XM_SLIDE_TOWARDS(ch->period,
 		                 ch->tone_portamento_target_period,