Merge pull request cert-manager#3989 from maelvls/fix-crd-generation

Controller-gen can now update CRDs like before
Art4Tech · May 12, 2021 · 3bb830c · 3bb830c
2 parents 2aa625e + 39c9c66
commit 3bb830c
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 30 deletions.
diff --git a/deploy/crds/crd-certificaterequests.yaml b/deploy/crds/crd-certificaterequests.yaml
@@ -30,14 +30,14 @@ spec:
     webhook:
       conversionReviewVersions: ["v1", "v1beta1"]
       clientConfig:
-        {{- if .Values.webhook.url.host }}
+        # {{- if .Values.webhook.url.host }}
         url: https://{{ .Values.webhook.url.host }}/convert
-        {{- else }}
+        # {{- else }}
         service:
-          name: {{ template "webhook.fullname" . }}
-          namespace: {{ .Release.Namespace | quote }}
+          name: '{{ template "webhook.fullname" . }}'
+          namespace: "{{ .Release.Namespace }}"
           path: /convert
-        {{- end }}
+          # {{- end }}
   versions:
     - name: v1alpha2
       subresources:

diff --git a/deploy/crds/crd-certificates.yaml b/deploy/crds/crd-certificates.yaml
@@ -30,14 +30,14 @@ spec:
     webhook:
       conversionReviewVersions: ["v1", "v1beta1"]
       clientConfig:
-        {{- if .Values.webhook.url.host }}
+        # {{- if .Values.webhook.url.host }}
         url: https://{{ .Values.webhook.url.host }}/convert
-        {{- else }}
+        # {{- else }}
         service:
-          name: {{ template "webhook.fullname" . }}
-          namespace: {{ .Release.Namespace | quote }}
+          name: '{{ template "webhook.fullname" . }}'
+          namespace: "{{ .Release.Namespace }}"
           path: /convert
-        {{- end }}
+          # {{- end }}
   versions:
     - name: v1alpha2
       subresources:

diff --git a/deploy/crds/crd-challenges.yaml b/deploy/crds/crd-challenges.yaml
@@ -28,14 +28,14 @@ spec:
     webhook:
       conversionReviewVersions: ["v1", "v1beta1"]
       clientConfig:
-        {{- if .Values.webhook.url.host }}
+        # {{- if .Values.webhook.url.host }}
         url: https://{{ .Values.webhook.url.host }}/convert
-        {{- else }}
+        # {{- else }}
         service:
-          name: {{ template "webhook.fullname" . }}
-          namespace: {{ .Release.Namespace | quote }}
+          name: '{{ template "webhook.fullname" . }}'
+          namespace: "{{ .Release.Namespace }}"
           path: /convert
-        {{- end }}
+          # {{- end }}
   versions:
     - additionalPrinterColumns:
         - jsonPath: .status.state

diff --git a/deploy/crds/crd-clusterissuers.yaml b/deploy/crds/crd-clusterissuers.yaml
@@ -27,14 +27,14 @@ spec:
     webhook:
       conversionReviewVersions: ["v1", "v1beta1"]
       clientConfig:
-        {{- if .Values.webhook.url.host }}
+        # {{- if .Values.webhook.url.host }}
         url: https://{{ .Values.webhook.url.host }}/convert
-        {{- else }}
+        # {{- else }}
         service:
-          name: {{ template "webhook.fullname" . }}
-          namespace: {{ .Release.Namespace | quote }}
+          name: '{{ template "webhook.fullname" . }}'
+          namespace: "{{ .Release.Namespace }}"
           path: /convert
-        {{- end }}
+          # {{- end }}
   versions:
     - name: v1alpha2
       subresources:

diff --git a/deploy/crds/crd-issuers.yaml b/deploy/crds/crd-issuers.yaml
@@ -27,14 +27,14 @@ spec:
     webhook:
       conversionReviewVersions: ["v1", "v1beta1"]
       clientConfig:
-        {{- if .Values.webhook.url.host }}
+        # {{- if .Values.webhook.url.host }}
         url: https://{{ .Values.webhook.url.host }}/convert
-        {{- else }}
+        # {{- else }}
         service:
-          name: {{ template "webhook.fullname" . }}
-          namespace: {{ .Release.Namespace | quote }}
+          name: '{{ template "webhook.fullname" . }}'
+          namespace: "{{ .Release.Namespace }}"
           path: /convert
-        {{- end }}
+          # {{- end }}
   versions:
     - name: v1alpha2
       subresources:

diff --git a/deploy/crds/crd-orders.yaml b/deploy/crds/crd-orders.yaml
@@ -28,14 +28,14 @@ spec:
     webhook:
       conversionReviewVersions: ["v1", "v1beta1"]
       clientConfig:
-        {{- if .Values.webhook.url.host }}
+        # {{- if .Values.webhook.url.host }}
         url: https://{{ .Values.webhook.url.host }}/convert
-        {{- else }}
+        # {{- else }}
         service:
-          name: {{ template "webhook.fullname" . }}
-          namespace: {{ .Release.Namespace | quote }}
+          name: '{{ template "webhook.fullname" . }}'
+          namespace: "{{ .Release.Namespace }}"
           path: /convert
-        {{- end }}
+          # {{- end }}
   versions:
     - name: v1alpha2
       subresources: