white space and minor adjustments

ArnoCB · Sep 27, 2024 · ccbf449 · ccbf449
1 parent 6140283
commit ccbf449
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 7 deletions.
diff --git a/.gitignore b/.gitignore
@@ -20,3 +20,4 @@ artisan.php
 package-lock.json
 package.json
 vite.config.js
+tags
diff --git a/.phpactor.json b/.phpactor.json
@@ -0,0 +1,4 @@
+{
+    "$schema": "/phpactor.schema.json",
+    "language_server_phpstan.enabled": false
+}
diff --git a/README.md b/README.md
@@ -56,3 +56,6 @@ parameters:
 - The PHPDoc standard (PSR-19) is a work in progress, but can be found at:
 https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc-tags.md
 
+### todo
+- no switch statements, but always match
+- not more than one elseif -> refactor to match
diff --git a/src/Rules/Documentation/ForbidSuppressAllPhpmdWarningsRule.php b/src/Rules/Documentation/ForbidSuppressAllPhpmdWarningsRule.php
@@ -23,8 +23,6 @@ public function getNodeType(): string
 
     public function processNode(Node $node, Scope $scope): array
     {
-
-
         return $node->getDocComment() !== null
                && (str_contains($node->getDocComment()->getText(), '@SuppressWarnings("PHPMD")')
                    || str_contains($node->getDocComment()->getText(), "@SuppressWarnings('PHPMD')"))

diff --git a/tests/Rules/ForbidElvisOperatorRuleTest.php b/tests/Rules/ForbidElvisOperatorRuleTest.php
@@ -5,5 +5,5 @@
         'vendor/bin/phpstan analyse tests/ExampleScripts/ScriptWithElvisOperator.php --error-format raw 2>&1
     ');
 
-    expect($output)->toContain( 'Use of the Elvis operator is forbidden.');
+    expect($output)->toContain('Use of the Elvis operator is forbidden.');
 });
diff --git a/tests/Rules/ForbidFunctionsWithoutReturnTypeTest.php b/tests/Rules/ForbidFunctionsWithoutReturnTypeTest.php
@@ -5,6 +5,5 @@
         'vendor/bin/phpstan analyse tests/ExampleScripts/FunctionWithoutReturnType.php --level 0 --error-format raw 2>&1'
     );
 
-    expect($output)
-        ->toContain('A return type is missing.');
+    expect($output)->toContain('A return type is missing.');
 });
diff --git a/tests/Rules/ForbidResponseInOrdinaryClassesRuleTest.php b/tests/Rules/ForbidResponseInOrdinaryClassesRuleTest.php
@@ -5,6 +5,5 @@
         'vendor/bin/phpstan analyse tests/ExampleScripts/OrdinaryClassWithHttpResponse.php --level 0 --error-format raw 2>&1'
     );
 
-    expect($output)
-        ->toContain('must not return a response type Illuminate\Http\Response. Wrong class type.');
+    expect($output)->toContain('must not return a response type Illuminate\Http\Response. Wrong class type.');
 });