Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enquiry for supporting vscode terminal #9

Open
jingwangsg opened this issue Feb 29, 2024 · 4 comments
Open

Enquiry for supporting vscode terminal #9

jingwangsg opened this issue Feb 29, 2024 · 4 comments
Labels
enhancement New feature / Improvement suggestion or request graphics Related to a graphics-based render style iterm2 Related to the 'iterm2' render style terminal support Lack of (or partial) support by a terminal emulator tmux Related to Tmux
Milestone
X.Y.Z

Comments

@jingwangsg
Copy link

Is your feature request related to a problem? Please describe.
Most of cases I use vscode tunnel to access remote server for convenience. Without proxy, ssh access within normal simluater (e.g. iTerm2) is impossible.

Describe the solution you'd like
It would be great if termvisage can support vscode internal terminal simulater.

Describe alternatives you've considered
Of course, I can use proxy to use ssh in iTerm2. Also, if tmux will supported soon, it should be a great alternative, since I'm able to run tmux inside vscode directly.

Additional context
Add any other context or screenshots about the feature request here.
@jingwangsg jingwangsg added the enhancement New feature / Improvement suggestion or request label Feb 29, 2024
@jingwangsg jingwangsg changed the title Enquiry Enquiry for supporting vscode terminal Feb 29, 2024
@AnonymouX47
Copy link
Owner

Hello!

Thanks for the request.

I'm yet to test this viewer (and term-image, the library it depends on) on xterm-addon-image which the VS Code terminal depends on.

In the mean time, please ensure image support is enabled and try to run termvisage with the options -S iterm2 --force-style. Though, I suspect output may be sorta garbled due to xterm-addon-image's cursor placement policy being different from the norm. Anyways, please let me know the results.

Once I've been able to test on xterm.js, I'll make any neccessary changes upstream (at term-image) to get things working out of the box.

Thanks.

@AnonymouX47
Copy link
Owner

About tmux support, that's planned and should hopefully come soon (though, to the library, term-image first) but note that there are various limitations to using graphics protocols within tmux.

@AnonymouX47 AnonymouX47 added graphics Related to a graphics-based render style iterm2 Related to the 'iterm2' render style terminal support Lack of (or partial) support by a terminal emulator tmux Related to Tmux labels Mar 3, 2024
@jingwangsg
Copy link
Author

jingwangsg commented Mar 3, 2024 •
edited
Loading

Hello!

Thanks for the request.

I'm yet to test this viewer (and term-image, the library it depends on) on xterm-addon-image which the VS Code terminal depends on.

In the mean time, please ensure image support is enabled and try to run termvisage with the options -S iterm2 --force-style. Though, I suspect output may be sorta garbled due to xterm-addon-image's cursor placement policy being different from the norm. Anyways, please let me know the results.

Once I've been able to test on xterm.js, I'll make any neccessary changes upstream (at term-image) to get things working out of the box.

Thanks.

Turning on Image Support and adding options -S iterm2 --force-style work great on latest vscode! Many thanks for your guidance and hard working:)

A minor issue is that the picture will lose a small portion at its bottom left corner. However, this does not affect the overall experience so far.
image
image

@AnonymouX47
Copy link
Owner

AnonymouX47 commented Mar 3, 2024 •
edited
Loading

Turning on Image Support and adding options -S iterm2 --force-style work great on latest vscode! Many thanks for your guidance and hard working:)

Glad to hear that 😃 and thanks for the quick response. You're welcome.

A minor issue is that the picture will lose a small portion at its bottom left corner. However, this does not affect the overall experience so far.

I see... as expected. It's due to the cursor-positioning issue with xterm-addon-image that I mentioned earlier. The "garbled" was actually referring to the TUI mode.

I intend to open an issue at the concerned repository after I've looked into it properly. I'll wait for the developer's response to this before going ahead with adding out-of-the-box support for the terminal emulator.

In the mean time, you can add the -H right option to apply right alignment to images. This should help avoid the erasure of some portion of the last line.

I'll get back to you as soon as there's any development.

Thank you.

@AnonymouX47 AnonymouX47 mentioned this issue Mar 5, 2024
Open
@AnonymouX47 AnonymouX47 added this to the X.Y.Z milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature / Improvement suggestion or request graphics Related to a graphics-based render style iterm2 Related to the 'iterm2' render style terminal support Lack of (or partial) support by a terminal emulator tmux Related to Tmux
Projects
None yet
Milestone
X.Y.Z
Development

No branches or pull requests
2 participants
@jingwangsg @AnonymouX47