[jsx][tsx] Wrong type of comments for React code. Fixes microsoft#6461

AmreeshTyagi · Jan 7, 2017 · d826ad6 · d826ad6
1 parent db859bf
commit d826ad6
Show file tree

Hide file tree

Showing 4 changed files with 48 additions and 5 deletions.
diff --git a/...ns/javascript/language-configuration.json → ...pt/javascript-language-configuration.json b/...ns/javascript/language-configuration.json → ...pt/javascript-language-configuration.json
diff --git a/extensions/javascript/package.json b/extensions/javascript/package.json
@@ -27,7 +27,7 @@
 				"extensions": [
 					".jsx"
 				],
-				"configuration": "./language-configuration.json"
+				"configuration": "./javascript-language-configuration.json"
 			},
 			{
 				"id": "javascript",
@@ -47,19 +47,31 @@
 				"mimetypes": [
 					"text/javascript"
 				],
-				"configuration": "./language-configuration.json"
+				"configuration": "./javascript-language-configuration.json"
+			},
+			{
+				"id": "jsx-tags",
+				"configuration": "./tags-language-configuration.json"
 			}
 		],
 		"grammars": [
 			{
 				"language": "javascriptreact",
 				"scopeName": "source.js",
-				"path": "./syntaxes/JavaScript.tmLanguage.json"
+				"path": "./syntaxes/JavaScript.tmLanguage.json",
+				"embeddedLanguages": {
+					"meta.tag.js": "jsx-tags",
+					"meta.tag.without-attributes.js": "jsx-tags"
+				}
 			},
 			{
 				"language": "javascript",
 				"scopeName": "source.js",
-				"path": "./syntaxes/JavaScript.tmLanguage.json"
+				"path": "./syntaxes/JavaScript.tmLanguage.json",
+				"embeddedLanguages": {
+					"meta.tag.js": "jsx-tags",
+					"meta.tag.without-attributes.js": "jsx-tags"
+				}
 			},
 			{
 				"scopeName": "source.js.regexp",

diff --git a/extensions/javascript/tags-language-configuration.json b/extensions/javascript/tags-language-configuration.json
@@ -0,0 +1,27 @@
+{
+	"comments": {
+		"blockComment": [ "{/*", "*/}" ]
+	},
+	"brackets": [
+		["{", "}"],
+		["[", "]"],
+		["(", ")"],
+		["<", ">"]
+	],
+	"autoClosingPairs": [
+		{ "open": "{", "close": "}" },
+		{ "open": "[", "close": "]" },
+		{ "open": "(", "close": ")" },
+		{ "open": "'", "close": "'", "notIn": ["string", "comment"] },
+		{ "open": "\"", "close": "\"", "notIn": ["string"] },
+		{ "open": "/**", "close": " */", "notIn": ["string"] }
+	],
+	"surroundingPairs": [
+		["{", "}"],
+		["[", "]"],
+		["(", ")"],
+		["<", ">"],
+		["'", "'"],
+		["\"", "\""]
+	]
+}
diff --git a/extensions/typescript/package.json b/extensions/typescript/package.json
@@ -68,7 +68,11 @@
 			{
 				"language": "typescriptreact",
 				"scopeName": "source.tsx",
-				"path": "./syntaxes/TypeScriptReact.tmLanguage.json"
+				"path": "./syntaxes/TypeScriptReact.tmLanguage.json",
+				"embeddedLanguages": {
+					"meta.tag.tsx": "jsx-tags",
+					"meta.tag.without-attributes.tsx": "jsx-tags"
+				}
 			}
 		],
 		"configuration": {