Skip to content

Commit

Permalink
Avoid backticks (fixes microsoft#13098)
Browse files Browse the repository at this point in the history
  • Loading branch information
chrmarti committed Oct 1, 2016
1 parent c968226 commit 602155b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/vs/workbench/electron-browser/actions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -521,12 +521,13 @@ export class ReportIssueAction extends Action {
}

private generateNewIssueUrl(baseUrl: string, name: string, version: string, commit: string, date: string, isPure: boolean, extensions:ILocalExtension[]): string {
// Avoid backticks, these can trigger XSS detectors. (https://github.com/Microsoft/vscode/issues/13098)
const osVersion = `${os.type()} ${os.arch()} ${os.release()}`;
const queryStringPrefix = baseUrl.indexOf('?') === -1 ? '?' : '&';
const body = encodeURIComponent(
`- VSCode Version: ${name} ${version}${isPure ? '' : ' **[Unsupported]**'} (${product.commit || 'Commit unknown'}, ${product.date || 'Date unknown'})
- OS Version: ${osVersion}
- Extensions: ${extensions.map(e => '`' + e.id + '`').join(', ')}
- Extensions: ${extensions.map(e => e.id).join(', ')}
Steps to Reproduce:
Expand Down

0 comments on commit 602155b

Please sign in to comment.