Rename GetBuildInfo to GetVersionInfo

Aloshi · Apr 13, 2023 · 840d4fa · 840d4fa
1 parent 131e6ff
commit 840d4fa
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/cmd/exporter/main.go b/cmd/exporter/main.go
@@ -21,7 +21,7 @@ func main() {
 	logstashUrl := config.LogstashUrl
 
 	log.Println("Application starting...")
-	versionInfo := config.GetBuildInfo()
+	versionInfo := config.GetVersionInfo()
 	log.Println(versionInfo.String())
 
 	collectorManager := collectors.NewCollectorManager(logstashUrl)

diff --git a/config/version.go b/config/version.go
@@ -16,8 +16,8 @@ var (
 	BuildDate = "unknown"
 )
 
-// GetBuildInfo returns a VersionInfo struct with the current build information.
-func GetBuildInfo() *VersionInfo {
+// GetVersionInfo returns a VersionInfo struct with the current build information.
+func GetVersionInfo() *VersionInfo {
 	return &VersionInfo{
 		Version:   Version,
 		GitCommit: GitCommit,

diff --git a/config/version_test.go b/config/version_test.go
@@ -6,7 +6,7 @@ import (
 )
 
 func TestGetBuildInfo(t *testing.T) {
-	versionInfo := GetBuildInfo()
+	versionInfo := GetVersionInfo()
 
 	if versionInfo.Version == "" {
 		t.Error("Expected Version to be set")

diff --git a/server/server.go b/server/server.go
@@ -19,7 +19,7 @@ func NewAppServer(host, port string) *http.Server {
 		http.Redirect(w, r, "/metrics", http.StatusMovedPermanently)
 	})
 	mux.HandleFunc("/healthcheck", getHealthCheck(config.LogstashUrl))
-	mux.HandleFunc("/version", getVersionInfoHandler(config.GetBuildInfo()))
+	mux.HandleFunc("/version", getVersionInfoHandler(config.GetVersionInfo()))
 
 	listenUrl := fmt.Sprintf("%s:%s", host, port)
 

diff --git a/server/versioninfo_test.go b/server/versioninfo_test.go
@@ -34,7 +34,7 @@ func TestHandleVersionInfo(t *testing.T) {
 	t.Parallel()
 	t.Run("normal case", func(t *testing.T) {
 		t.Parallel()
-		ts := httptest.NewServer(http.HandlerFunc(getVersionInfoHandler(config.GetBuildInfo())))
+		ts := httptest.NewServer(http.HandlerFunc(getVersionInfoHandler(config.GetVersionInfo())))
 		defer ts.Close()
 
 		resp, err := http.Get(ts.URL)
@@ -54,7 +54,7 @@ func TestHandleVersionInfo(t *testing.T) {
 			t.Fatalf("failed to decode JSON: %v", err)
 		}
 
-		expectedVersionInfo := config.GetBuildInfo()
+		expectedVersionInfo := config.GetVersionInfo()
 		if versionInfo != *expectedVersionInfo {
 			t.Errorf("expected version info: %+v, but got: %+v", *expectedVersionInfo, versionInfo)
 		}