Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logs are written synchronously #6

Open
cotz1995 opened this issue Jan 3, 2019 · 2 comments
Open

logs are written synchronously #6

cotz1995 opened this issue Jan 3, 2019 · 2 comments
Assignees
@AlanBarber
Labels
enhancement work in progress
Milestone
Version 3.0.0

Comments

@cotz1995
Copy link

cotz1995 commented Jan 3, 2019

Currently, logs sent to HttpEventCollectorSender are flushed synchronously using FlushSync(). See

log4net.Appender.Splunk/src/log4net.Appender.Splunk/SplunkHttpEventCollector.cs

Line 81 in c5b5b68

_hecSender.FlushSync();

I can see this is advantageous over fire and forget in that exceptions are not lost. However, if the http requests to the Splunk system hang so does the application. Moreover, I use a mock api (WireMock) and delayed the response by a significant amount of time. The entire app hangs on any logging calls. My suggestion is to use FlushAsync().

I'd be more than happy to make a pull request for this, but I currently don't have permissions to make new branches.

Thanks!
Cory
@AlanBarber
Copy link
Owner

yeah, I have a version for nlog that was cleaned up to do async and improved error handling. I've been meaning to get around to migrating the code over to this log4net version. I'll try to prioritize it for the next release.

@AlanBarber AlanBarber self-assigned this Jan 7, 2019
@AlanBarber AlanBarber added this to the Version 2.2.0 milestone Jan 7, 2019
@ancgate
Copy link

ancgate commented Mar 3, 2021

any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlanBarber AlanBarber

Labels
enhancement work in progress
Projects
None yet
Milestone
Version 3.0.0
Development

No branches or pull requests
3 participants
@AlanBarber @ancgate @cotz1995