Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlCache retains data (and other properties), possible memory leak #2027

Open
paulrutter opened this issue Jan 8, 2025 · 1 comment · May be fixed by #2028
Open

sqlCache retains data (and other properties), possible memory leak #2027

paulrutter opened this issue Jan 8, 2025 · 1 comment · May be fixed by #2028

Comments

@paulrutter
Copy link
Contributor

We recently observed an out of memory situation with AlaSQL 4.6.0.
It seems like the sqlCache (which is enabled by default), retains more information than it should.

See the attached screenshot of the heapdump, where it shows the sqlCache retaining properties like data, but also other information.

I doubt that this information should be stored in the cache, as it makes the cache much larger than required.
As a workaround i can either disable the cache, or reduce the MAXSQLCACHESIZE, but i'm not sure of the performance implications of doing this.

It seems like the objects stored in the cache should be stripped of any query execution specific information.

image
image

@mathiasrw what do you think?
paulrutter added a commit to blueconic/alasql that referenced this issue Jan 8, 2025
@paulrutter
AlaSQL#2027 sqlCache retains data (and other properties), possible me…
8bbc1d8 
…mory leak AlaSQL#2027

- Remove the `data` property from the sql cache after executing the query
@paulrutter paulrutter linked a pull request Jan 8, 2025 that will close this issue
Open
@paulrutter
Copy link
Contributor Author

See #2028.

paulrutter added a commit to blueconic/alasql that referenced this issue Jan 8, 2025
@paulrutter
AlaSQL#2027 sqlCache retains data (and other properties), possible me…
15d706b 
…mory leak AlaSQL#2027

- Add assertions
paulrutter added a commit to blueconic/alasql that referenced this issue Jan 9, 2025
@paulrutter
AlaSQL#2027 sqlCache retains data (and other properties), possible me…
c77796e 
…mory leak AlaSQL#2027

- Add assertions
paulrutter added a commit to blueconic/alasql that referenced this issue Jan 9, 2025
@paulrutter
AlaSQL#2027 sqlCache retains data (and other properties), possible me…
963d7f0 
…mory leak AlaSQL#2027

- Add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove data from the stored sqlCache statement closure blueconic/alasql
1 participant
@paulrutter