Correcting filter size typo (keras-team#288)

* Correcting filter size typo At the "Build the generators" the last layer is said to have `filter size of 1` but actually, it also has `filter size of 7` as the first layer, it has `stride size of 1` what may have caused the typo. * Missing parameter at "GANMonitor" At the `GANMonitor` class it is being used hardcoded `4` but there is actually a paramter defined at the `__intit__` `num_img` that could be used there, I think that this was the initial purpose. * Filter size typo and "GANMonitor" parameter Filter size typo - At the "Build the generators" the last layer is said to have `filter size of 1` but actually, it also has `filter size of 7` as the first layer, it has `stride size of 1` what may have caused the typo. "GANMonitor" parameter - At the `GANMonitor` class it is being used hardcoded `4` but there is actually a parameter defined at the `__intit__` `num_img` that could be used there, I think that this was the initial purpose. * Filter size typo and "GANMonitor" parameter (.md) Filter size typo - At the "Build the generators" the last layer is said to have `filter size of 1` but actually, it also has `filter size of 7` as the first layer, it has `stride size of 1` what may have caused the typo. "GANMonitor" parameter - At the `GANMonitor` class it is being used hardcoded `4` but there is actually a parameter defined at the `__intit__` `num_img` that could be used there, I think that this was the initial purpose.
Akora-IngDKB · Oct 31, 2020 · 782069e · 782069e
1 parent c874c5b
commit 782069e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/examples/generative/cyclegan.py b/examples/generative/cyclegan.py
@@ -281,7 +281,7 @@ def upsample(
 u128 ====|
          |-> 2 upsampling blocks
 u64  ====|
-c7s1-3 => Last conv block with `tanh` activation, filter size of 1.
+c7s1-3 => Last conv block with `tanh` activation, filter size of 7.
 ```
 """
 
@@ -542,7 +542,7 @@ def __init__(self, num_img=4):
 
     def on_epoch_end(self, epoch, logs=None):
         _, ax = plt.subplots(4, 2, figsize=(12, 12))
-        for i, img in enumerate(test_horses.take(4)):
+        for i, img in enumerate(test_horses.take(self.num_img)):
             prediction = self.model.gen_G(img)[0].numpy()
             prediction = (prediction * 127.5 + 127.5).astype(np.uint8)
             img = (img[0] * 127.5 + 127.5).numpy().astype(np.uint8)

diff --git a/examples/generative/ipynb/cyclegan.ipynb b/examples/generative/ipynb/cyclegan.ipynb
@@ -369,7 +369,7 @@
     "u128 ====|\n",
     "         |-> 2 upsampling blocks\n",
     "u64  ====|\n",
-    "c7s1-3 => Last conv block with `tanh` activation, filter size of 1.\n",
+    "c7s1-3 => Last conv block with `tanh` activation, filter size of 7.\n",
     "```"
    ]
   },
@@ -680,7 +680,7 @@
     "\n",
     "    def on_epoch_end(self, epoch, logs=None):\n",
     "        _, ax = plt.subplots(4, 2, figsize=(12, 12))\n",
-    "        for i, img in enumerate(test_horses.take(4)):\n",
+    "        for i, img in enumerate(test_horses.take(self.num_img)):\n",
     "            prediction = self.model.gen_G(img)[0].numpy()\n",
     "            prediction = (prediction * 127.5 + 127.5).astype(np.uint8)\n",
     "            img = (img[0] * 127.5 + 127.5).numpy().astype(np.uint8)\n",
@@ -863,4 +863,4 @@
  },
  "nbformat": 4,
  "nbformat_minor": 0
-}
+}
diff --git a/examples/generative/md/cyclegan.md b/examples/generative/md/cyclegan.md
@@ -298,7 +298,7 @@ R256 ====|
 u128 ====|
          |-> 2 upsampling blocks
 u64  ====|
-c7s1-3 => Last conv block with `tanh` activation, filter size of 1.
+c7s1-3 => Last conv block with `tanh` activation, filter size of 7.
 ```
 
 
@@ -566,7 +566,7 @@ class GANMonitor(keras.callbacks.Callback):
 
     def on_epoch_end(self, epoch, logs=None):
         _, ax = plt.subplots(4, 2, figsize=(12, 12))
-        for i, img in enumerate(test_horses.take(4)):
+        for i, img in enumerate(test_horses.take(self.num_img)):
             prediction = self.model.gen_G(img)[0].numpy()
             prediction = (prediction * 127.5 + 127.5).astype(np.uint8)
             img = (img[0] * 127.5 + 127.5).numpy().astype(np.uint8)