Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test set drawer checkpoint-2 #2373

Merged
merged 19 commits into from
Dec 26, 2024
Merged

Test set drawer checkpoint-2 #2373

merged 19 commits into from
Dec 26, 2024

Conversation

ashrafchowdury
Copy link
Collaborator

@ashrafchowdury ashrafchowdury commented Dec 13, 2024 •
edited
Loading

Description

This PR aims to add smart features to the Test set drawer, eliminating as much manual work as possible.

Features:

  • Auto-generate columns for the existing test set and new test set.
  • Edit spans on the editor
  • Added (edited) tag on the span that is being updated from the editor
  • Memorized last used Test set config if being used.

Related Issue

Closes AGE-1468

@vercel Vercel
Copy link

vercel bot commented Dec 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2024 10:57am
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2024 10:57am

@ashrafchowdury ashrafchowdury marked this pull request as ready for review December 17, 2024 12:15
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Dec 17, 2024
ardaerzin
ardaerzin approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@ardaerzin ardaerzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ardaerzin
ardaerzin requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@ardaerzin ardaerzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small issues

agenta-web/src/components/pages/observability/drawer/TestsetDrawer/TestsetDrawer.tsx Outdated Show resolved Hide resolved
agenta-web/src/components/pages/observability/drawer/TestsetDrawer/TestsetDrawer.tsx Outdated Show resolved Hide resolved
ardaerzin
ardaerzin approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@ardaerzin ardaerzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jp-agenta jp-agenta merged commit 06803f5 into dev Dec 26, 2024
4 of 6 checks passed
@jp-agenta jp-agenta deleted the feat/testset-drawer-checkpoint-2 branch December 26, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardaerzin ardaerzin ardaerzin approved these changes

Assignees
No one assigned
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashrafchowdury @ardaerzin @jp-agenta