Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User rule for graph.facebook.com does not block the request completely #5539

Open
4 of 6 tasks
Nzzyme opened this issue Dec 8, 2024 · 19 comments
Open
4 of 6 tasks

User rule for graph.facebook.com does not block the request completely #5539

Nzzyme opened this issue Dec 8, 2024 · 19 comments
Assignees

Comments

@Nzzyme
Copy link

Nzzyme commented Dec 8, 2024

Please answer the following questions for yourself before submitting an issue

  • Filters were updated before reproducing an issue
  • I checked the knowledge base and found no answer
  • I checked to make sure that this issue has not already been filed

AdGuard version

4.7

Environment

  • OS version: Android 14
  • Device:

HTTPS filtering

  • yes, I do

Root access

  • yes, I have it

Integration with AdGuard VPN

  • yes, I do

Routing mode

Local VPN

Ad Blocking

AdGuard Base filter, AdGuard Mobile Ads filter, EasyList

Privacy

AdGuard Tracking Protection filter, AdGuard URL Tracking filter, EasyPrivacy, Peter Lowe's Blocklist, Fanboy's Anti-Facebook List, Fanboy's Anti-thirdparty Fonts

Social

AdGuard Social Media filter

Annoyances

AdGuard Annoyances filter, AdGuard Cookie Notices filter, AdGuard Popups filter, AdGuard Mobile App Banners filter, AdGuard Other Annoyances filter, AdGuard Widgets filter, Adblock Warning Removal List, Fanboy's Annoyances, I don't care about cookies, EasyList Cookie List, Dandelion Sprout's Annoyances List

Security

Online Malicious URL Blocklist

Language-specific

No response

Other

AdGuard DNS filter

Which DNS server do you use?

AdGuard DNS

DNS protocol

DNS-over-HTTPS

Custom DNS

No response

What Stealth Mode options do you have enabled?

No response

Issue Details

Steps to reproduce:

  1. Install and open the JioSaavn app (but any other app should also work in my opinion)
  2. Open AG and navigate to Statistics > Recent activity
  3. Add a custom blocking rule for the domain (graph.facebook.com)
  4. Wait for Protection to be completely restarted
  5. Close the JioSaavn app and later reopen it.
  6. Repeat step 2 and clear the recent activity.
  7. You will observe in the "Recent activity" that there are many new connections/entries for "graph.fabook.com" but some are blocked and some are not (see screenshot).

Expected Behavior

Once a blocking/allow rule is applied on a domain, it should be applied for all the future connection attempts.

Actual Behavior

Some connections to this domain are being blocked and some are not.

Screenshots

image

Additional Information

No response

@Nzzyme Nzzyme added the Bug label Dec 8, 2024
@adguard-bot adguard-bot assigned maxikuzmin and unassigned Versty Dec 9, 2024
@maxikuzmin maxikuzmin changed the title Inconsistent Blocking User rule for graph.facebook.com does not block the request completely Dec 9, 2024
@maxikuzmin
Copy link
Contributor

@Nzzyme I have tested this on several apps but it is not repeated on my device. Please repeat the steps again and after restarting protection - force stop JioSaavn app, maybe the app process remains and the rule is not applied completely

@Nzzyme
Copy link
Author

Nzzyme commented Dec 9, 2024

@Nzzyme I have tested this on several apps but it is not repeated on my device. Please repeat the steps again and after restarting protection - force stop JioSaavn app, maybe the app process remains and the rule is not applied completely

I just checked and I am able to reproduce this issue at my end. This does not just happen with the domain "graph.facebook,com" but with other domains as well.

Another example:

Domain: "app.adjust.net.in"
This domain was added to the block list yesterday (User Rule) and later when I open the JioSaavn app today, I am able to see the connection to the domain instead of blocking it. See screenshots below:

image

image

Screenshot_2024-12-09-21-55-59-982_com adguard android

Note that I have restarted the phone couple of times and ensured that the protection is restarted completely before the test. This has only started happening after the recent update.

@maxikuzmin
Copy link
Contributor

@Nzzyme I'll watch my device some more. Do I understand correctly that you select 2 checkboxes when adding a blocking rule? "Apply only for..." and "Give a higher priority to the rule"?

@Nzzyme
Copy link
Author

Nzzyme commented Dec 10, 2024

@Nzzyme I'll watch my device some more. Do I understand correctly that you select 2 checkboxes when adding a blocking rule? "Apply only for..." and "Give a higher priority to the rule"?

That is correct. Both boxes checked. The issue is not just with that one domain but will all the "user" rules.

One more example that I spotted today:

Screenshot_2024-12-10-22-20-24-914_com adguard android

@maxikuzmin
Copy link
Contributor

@Nzzyme in order to troubleshoot this issue, we need to get your application logs.

Here's what we need you to do:

  1. Enable debug logging:
    Settings -> General -> Advanced -> Logging level -> Debug.
  2. Reproduce the problem, then remember the exact time when it happened.
  3. Collect logs:
    Settings -> General -> Advanced -> Export logs and system info.
  4. Send this file to qa@adguard.com:
    • include [android] keyword and 5539 in the subject of your email
    • specify the exact time when the issue occurred

@maxikuzmin
Copy link
Contributor

@Nzzyme could you send a screenshot of the detailed description of the two requests? Blocked and not blocked?
Also send the full rule you have added
It could also be a problem with DoH DNS, try switching to DoT DNS for a while

@Nzzyme
Copy link
Author

Nzzyme commented Dec 11, 2024

@Nzzyme could you send a screenshot of the detailed description of the two requests? Blocked and not blocked? Also send the full rule you have added It could also be a problem with DoH DNS, try switching to DoT DNS for a while

I plan to do this in the next couple of days. However, just to let you know, this is not related to DNS but regular "User" rules as per the screenshots provided so far.

Protection > Ad blocking > User rules

@Nzzyme
Copy link
Author

Nzzyme commented Dec 13, 2024

@Nzzyme could you send a screenshot of the detailed description of the two requests? Blocked and not blocked? Also send the full rule you have added It could also be a problem with DoH DNS, try switching to DoT DNS for a while

Unblocked:
Screenshot_2024-12-13-14-19-21-333_com adguard android

Blocked:
Screenshot_2024-12-13-16-31-57-465_com adguard android

@Nzzyme
Copy link
Author

Nzzyme commented Dec 13, 2024

@Nzzyme in order to troubleshoot this issue, we need to get your application logs.

Here's what we need you to do:

  1. Enable debug logging:
    Settings -> General -> Advanced -> Logging level -> Debug.

  2. Reproduce the problem, then remember the exact time when it happened.

  3. Collect logs:
    Settings -> General -> Advanced -> Export logs and system info.

  4. Send this file to qa@adguard.com:

    • include [android] keyword and 5539 in the subject of your email
    • specify the exact time when the issue occurred

Sent it. Please check

@maxikuzmin
Copy link
Contributor

@Nzzyme your logs contain viruses, I can't open them, please overwrite the logs

@Nzzyme
Copy link
Author

Nzzyme commented Dec 17, 2024

@Nzzyme your logs contain viruses, I can't open them, please overwrite the logs

That's weird. The file must have been corrupted as I noticed it took a lot longer to attach it in the email. I'll try sending another one later.

@maxikuzmin
Copy link
Contributor

@Nzzyme any news?

@Nzzyme
Copy link
Author

Nzzyme commented Dec 17, 2024

@Nzzyme any news?

Resent it. Please check.

@maxikuzmin
Copy link
Contributor

@Nzzyme I noticed that you have a blocked IPv4 request and a allowed IPv6 request, this is strange...
Please try removing the high priority checkbox from the rule, and see if this problem continues to recur?

@Nzzyme
Copy link
Author

Nzzyme commented Dec 18, 2024

@Nzzyme I noticed that you have a blocked IPv4 request and a allowed IPv6 request, this is strange... Please try removing the high priority checkbox from the rule, and see if this problem continues to recur?

I checked my "User Rules" and I only see a blocked rule there. Note that this is not a DNS rule
Can you let me know where do you see the Allow rule? (in which filter subscription)? I have many filters

@maxikuzmin
Copy link
Contributor

@Nzzyme you just have Processed status on one screenshot and Blocked status on the second screenshot.
You only have the rule on the screenshot of the blocked request. You didn't originally have this request blocked, and there are no rules for it

@Nzzyme
Copy link
Author

Nzzyme commented Dec 20, 2024

@Nzzyme you just have Processed status on one screenshot and Blocked status on the second screenshot. You only have the rule on the screenshot of the blocked request. You didn't originally have this request blocked, and there are no rules for it

I don't follow what you have mentioned. I have a block rule set for "graph.facebook.com" but why are all requests not blocked and instead some are blocked and some are not when that app is launched? It's not just with graph.facebook.com.

@Nzzyme
Copy link
Author

Nzzyme commented Dec 23, 2024

@maxikuzmin Any update?

@maxikuzmin
Copy link
Contributor

@Nzzyme sorry for the wait, we need a little more time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants