-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
High CPU consumption in v4.6 due to a TCP/IP stack implementation bug #5505
Comments
Things to check:
|
|
@ameshkov Can this usage related to this issue in any way? P.S: I have a S23 Plus however. |
@derKief just in case, could you please try nighlty version of AG? It has just minor improvements, but for some reason we don't see reports from Samsung owners on the nightly build (and the two I saw on GH seem to have normal usage). |
Ever since at least 4.6.4, Adguard has been the top consumer of battery life on my (Samsung) phone every time I've checked, with no change in my usage of the phone. I'll try the nightly today, but 4.6.204 definitely did not fix the issues. And yes, I have sent the logs to support, but I got an email this morning closing the ticket, with no other information. I don't want to just pile on this ticket with a useless comment, but this issue is definitely not resolved with 4.6.204. |
We responded to you yesterday in ticket #978524 before closing it. In our response, we informed you that the app logs were forwarded to our development team and provided a link to this issue so you can track further progress. |
Yes there was a link to this issue, which is why I'm here. It sounded above like victory was being declared a bit too early, but perhaps I misread that. Back on topic, I've used the v4.7 Nightly 44 this morning for about 3 hours, and AdGuard has used 19.1% of my battery in that time, 3 times more than the next app. Device battery usage is still higher than normal with the latest nightly. :( |
@abryant-hv what exact Samsung model are you using just in case? |
It's a "Galaxy A52 5G". Model name is "SM-A526U" |
with the Nightly 44 (4.7.89) it has gotten better but in direct comparison to the stable 4.5 it is still too high/much. @ameshkov I replied to your private e-mail. Waiting on feedback. |
Today I tried to update to the new 4.7 Nightly 45, but it didn't work. The app crashed and wouldn't start anymore. |
Mhh...weirdly in my case the Nightly 45 (at least for the moment) seems to be very optimised. Check it out here: |
Had this been fixed yet. I had to turn it off the drain was so bad. Where can I find 4.5th go back to it |
no. i would just go back to 4.5 for now |
Yes where is it to download please |
or directly from here -> https://github.com/AdguardTeam/AdguardForAndroid/releases/tag/v4.5 |
I know it's a Samsung ticket but i have the same problem on a Xiaomi Phone. I have reverted to 4.5 and will be watching this ticket to see if any solutions manifests itself. |
good to know its an all around issue |
I don't think the 4.6 build 204 Hotfix version completely fixed the problem. The battery drain caused by the calendar timezone change when phone is idle is gone. However the app still seems to cause very high CPU usage when it's not idle, causing phone to heat up badly and battery goes down insanely fast. I posted here. The AdGuard battery stat screen shows 24-hour usage is normal, but when I use the phone, CPU temp goes through the roof, approaching around 80C sometimes in as little as 2-5 minutes. And the battery drops super fast. The phone becomes a very effective hand warmer. I noticed this while using the Bing app and AliExpress app in particular. I went back to v4.5. Phone still got warm while using those apps but not as much as the v4.6 build 204 Hotfix version. v4.6 build 204 Hotfix - CPU temp 70-80C while using apps. Temp consistently above 70C with spikes to 80C. v4.5 - CPU temp 60-70C while using apps. Temp around 60C with a few spikes to 70C. phone is Vivo X100 Pro. |
I can now confirm that this is not just a Samsung problem. My wife's Poco X6 Pro is also affected and here too we are back to v4.5 |
Heh...Unfortunately, today the latest Nightly started to drain my battery again, and this after starting to watch a TV series from web browser. This problem didn't happen during normal navigation, maybe this can helpful to find the root of problem @ameshkov? |
Xiaomi (poco F6) too. i first think my devices broken XD. after restart and start adguard seem fine. security patch same 2024-10 -1, could this be the cause? i feel before update to this patch don't have this problem, but after update at today i got this problem CPU locked at high speed (via CPUZ) |
I downgraded even more today to v4.4.1 as I find even with v4.5 the CPU temp seems rather elevated. Before testing v4.4.1, CPU temp was 100% under 40C. on v4.5, after using the same apps, CPU temp would be between 60-70C. so far my results: gonna do the same tests again tomorrow. |
@0xrxL why do you think it's a "drain" and not a normal usage? Did it stop after you finished watching? Is it specific to that website? |
@muchqs tbh temperature numbers do not provide us with any insights into the issue. AdGuard prints CPU usage numbers measured by the system, it'd be helpful if you compare them between different versions. Basically, we need every record in the log that contains |
Nightly 1 doesn't include the fix. |
@derKief @jordansworld @sk1llsh0t Nightly 3 with the new fixed CoreLibs is available. Try it. 👍 |
thankyou for your hardwork! |
Unfortunately for me the nightly 3 build did not fix the problem. It still consumes 14%+ cpu and 20% battery consumption. |
@derKief thanks for your help! I understand that it is annoying and we're trying to figure it out.
The bad thing here is that I don't understand it either. We stopped at the very same point - we identified the place where the TCP packet is getting stuck. We then added some extra logging there, but so far no one was able to send us a log file where the issue was reproduced. The only difference between stable and nightly is having this extra logging. Folks, I have to say it again: we are not able to reproduce it on our devices, we need debug-level logs to figure it out. Ideally, from the latest nightly version. At this point the procedure is rather simple:
|
@ameshkov I realize that you are trying to solve the problem, but this constant back and forth is not nice and takes time. I've now tried another test and installed 4.8 nightly 3. So far everything is fine and there are no problems. The last time I installed stable 4.7, the problem was immediately apparent. So I can't understand why the only difference between stable 4.7 and 4.8 nightly 3 is the extended logging. I'll leave it like this for now and continue to observe. |
@derKief this difference makes me believe that we're dealing with a race condition that is very sensitive to timings, the worst kind. Adding extra logging to these functions adds a microsecond-delay and this improves the situation and makes the issue happen less often. It does not mean that the issue is fully fixed, it should manifest itself eventually. Some people in comments were saying that they're having that issue on the nightly version too, maybe they can help. @sk1llsh0t @jordansworld if you can reproduce this with the nightly build, please try collecting the debug log. |
I've set debug logging on. I'll let it run a bit (until the issue appears). Do i just send the log in through the report a bug option in the app or is there another way you prefer to get it? |
@sk1llsh0t it'd be better if you export the full log via the app and then send an email to |
Logs sent. |
Short interim report with 4.8 nightly 3:
I'll let it run until tomorrow but it seems that the problem still exists, although not as extreme as with the stable versions 4.6 and 4.7 |
Final conclusion: |
I have the same issues (high battery drain) with my Galaxy S23 Ultra (latest updates applied). Where can I download specific nightly apk versions? I need especially version 4.7 nightly 48 or later 53 which seem to have worked for me (later on, especially with 4.8 nightly it started again) |
Any news here ? Anyone tried new stable 4.7.1 ? Changelog is somehow not very informative: And what about 4.8 Nightly 4 ? |
Nightly 4 has the same issue |
I'm still having issues on my Motorola and Pixel phones with the latest stable version. |
@ameshkov Any updates sir? |
Has this topic died down or why has there been no update or statement for days? |
probably holidays and people being away with their families. |
pretty sure ... but a short status update before the holidays would have been nice |
Sorry, yeah, holidays indeed mess with us. Merry Christmas to everyone! @sk1llsh0t thanks for sending the logs! I may be wrong, but from the log it looks like you have quite a lot of statistics. Am I right? This looks like a legit issue to me, but again it's unrelated to the one I saw in @derKief's logs. I'll return tomorrow with some specifics. |
@sk1llsh0t confirmed the issue. Temporary solution: clear statistics, the situation will normalize. Proper solution will be ready later. |
When I tap on the stats tab, I just see 3 green dots in the middle of the screen and nothing loads. The app appears to freeze. I'm not sure how to clear stats without going to that tab. Maybe I'll just wait for the fix to be released. |
@sk1llsh0t you may need to wait for quite some time until the stats are loaded or clear the app data. Here's the explanation for the issue: AdGuard at startup goes through statistics and tries to "compress" it, i.e. merge records for the old dates. There's a bug in this algorithm that may lead to the issue that you're having. |
@ameshkov |
@derKief no update unfortunately. So far your's are the only case where we saw that issue and unlike @sk1llsh0t's issue we cannot reproduce it. With @sk1llsh0t's we've been able to "generate" statistics database that causes the issue, but with this TCP issue we failed despite trying different ways to overload the TCP stack. What makes it really problematic, it seems that enabling debug-level logging resolves your issue. It may sound strange, but it sometimes happens, it's enough to introduce a slightest delay. Because of that we'll have to resort to ugly solutions: instead of asking you to collect debug-level log we'll try to detect the problematic condition and crash the app when it happens (and at that point we'll log everything required to troubleshoot it further). This change will come in one of the following nightlies, I'll announce it here. One more thing: thank you so much to everyone that's helping us figure this all out, I don't think we could manage without you! |
I also still have the issue in the latest nightly, with nearly 30% battery usage, also over night when in flight mode... I have asked three weeks ago if there are any apks for previous nightly builds? |
@0x4a4700 which one do you need? Could you please collect log as described here? |
Please answer the following questions for yourself before submitting an issue
AdGuard version
v4.6.4 (204)
Environment
HTTPS filtering
Root access
Integration with AdGuard VPN
Routing mode
Local VPN
Ad Blocking
No response
Privacy
No response
Social
No response
Annoyances
No response
Security
No response
Language-specific
No response
Other
No response
Which DNS server do you use?
DNS protection disabled
DNS protocol
None
Custom DNS
No response
What Stealth Mode options do you have enabled?
No response
Issue Details
The issue was originally reported by @derKief, check out the logs analysis here:
#5499 (comment)
To sum it up, AdGuard v4.6 consumes several times more than v4.5
Expected Behavior
No response
Actual Behavior
The usage should be more or less the same in v4.5 and v4.6.
Screenshots
No response
Additional Information
No response
The text was updated successfully, but these errors were encountered: