feat: Add custom browser name option #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for submitting this, really nice to see! Will take a look at it and review it when I have some time, but from a quick glance it looks like a good solution! |
|
What are your plans for merging this request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here was to add an option to override the browser name that is found in the user agent. This is because browsers such as Brave intentionally disguise themselves as Chrome and this causes issues that prevent the Browser tab in the web-ui from working correctly.
See:
ActivityWatch/activitywatch#461
This should resolve that issue without having to maintain custom code to get the correct browser name. This alone will not automatically work because of a previous work-around that was made, but will require that ActivityWatch/aw-webui#283 also be merged so that everything is correctly mapped.