This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Remove all references to UIWebView on 2.x version #4629
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals ⚽
Remove all references to
UIWebView
to allow legacy apps that can't update to version 4.x to keep sending updates to the AppStore.Implementation Details 🚧
I'm aware that this is NOT an optimal fix.
The optimal fix is the one released in the 4.x, which actually replaces
UIWebView
withWKWebView
.I'm also aware that this is a legacy branch that requires less attention from you, so implementing that same fix to this branch is way out of your scope.
That said:
UIWebView
UIWebView
within a monthUIWebView
category will no longer be able to use it and successfully release an update to the AppStoreI think it's safe to just remove every reference to
UIWebView
from this branch to allow legacy apps to still send minor updates and bugfixes.It may not be useful to many of your users, but I'm sure there is someone (like me) who has a really old app that:
UIWebView
categoryI think that merging this pull request could help them a lot.
Testing Details 🔍
I didn't test anything since this is just the removal of the
UIWebView
references.