Better handling of remote commit confirmation in TxPublisher #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1905 +/- ##
==========================================
+ Coverage 87.48% 87.51% +0.02%
==========================================
Files 159 159
Lines 12086 12088 +2
Branches 487 515 +28
==========================================
+ Hits 10574 10579 +5
+ Misses 1512 1509 -3
|
pm47
reviewed
Aug 16, 2021
eclair-core/src/main/scala/fr/acinq/eclair/channel/publish/ReplaceableTxPublisher.scala
Show resolved
Hide resolved
We used to check the feerate before checking whether the commit tx was already confirmed: when the commit feerate was good enough, we would respawn a publish actor every block whereas the commit tx was already confirmed.
This ensures the bitcoind wallet won't keep the transaction around and avoid using its inputs for other transactions. Fixes #1898
t-bast
force-pushed
the
tx-publisher-improvements
branch
from
1b3dbda to
7a1ce33
Compare
pm47
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is split in two independent commits.
In the first commit, we fix a (harmless) issue where we kept spawning
TxPublisheractors to spend anchor outputs even when the commit tx was confirmed if the feerate was already high enough. This was spamming the logs for no reason (and spawning actors that immediately stopped themselves), we should instead check the status of the commit tx as the first precondition to spending anchor outputs.In the second commit, we call
bitcoind'sabandontransactionwhen 2nd-stage txs are evicted from the mempool because their parent is replaced (e.g. the remote commit tx is confirmed instead of our local commit tx). This ensures thebitcoindwallet will not keep these obsolete transactions in its DB and reserve their inputs for no good reason.Fixes #1898