bail on first non-assert (dart-lang#1873)

5lineofcode · Dec 5, 2019 · f2a2687 · f2a2687
1 parent 7ddeafe
commit f2a2687
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/lib/src/rules/always_require_non_null_named_parameters.dart b/lib/src/rules/always_require_non_null_named_parameters.dart
@@ -120,6 +120,9 @@ class _Visitor extends SimpleAstVisitor<void> {
       for (final statement in body.block.statements) {
         if (statement is AssertStatement) {
           _checkAssert(statement.condition, params);
+        } else {
+          // Bail on first non-assert.
+          return;
         }
       }
     }

diff --git a/test/rules/always_require_non_null_named_parameters.dart b/test/rules/always_require_non_null_named_parameters.dart
@@ -6,6 +6,17 @@
 
 import 'package:meta/meta.dart';
 
+var condition = true;
+
+m0({
+  Object a, // OK
+}) {
+  if (condition) {
+    return;
+  }
+  assert(a != null);
+}
+
 m1(
   a,
   b,