Consider nested TypeNames when counting uses. (dart-lang#1857)

Child TypeNames in the AST being ignored due to missing call to super results in false positives in cases such as type arguments.
5lineofcode · Dec 2, 2019 · ed31be8 · ed31be8
1 parent 345c31d
commit ed31be8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/lib/src/rules/avoid_private_typedef_functions.dart b/lib/src/rules/avoid_private_typedef_functions.dart
@@ -52,6 +52,7 @@ class _CountVisitor extends RecursiveAstVisitor {
   @override
   visitTypeName(TypeName node) {
     if (node.name.name == type) count++;
+    super.visitTypeName(node);
   }
 }
 

diff --git a/test/rules/avoid_private_typedef_functions.dart b/test/rules/avoid_private_typedef_functions.dart
@@ -24,3 +24,11 @@ _F5 v5b;
 typedef void _F6(); // OK
 _F6 f6a() => null;
 _F6 f6b() => null;
+
+typedef _F7 = void Function(); // OK
+m7(_F7 f) => null;
+List<_F7> l7 = [];
+
+typedef void _F8(); // OK
+m8(_F8 f) => null;
+List<_F8> l8 = [];