Remove unnecessary null check before method call (flowable#3069)

5721617zzw · Nov 2, 2021 · 5c5f6fe · 5c5f6fe
1 parent 3b8e2f5
commit 5c5f6fe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...c/main/java/org/flowable/cmmn/engine/impl/behavior/impl/DecisionTaskActivityBehavior.java b/...c/main/java/org/flowable/cmmn/engine/impl/behavior/impl/DecisionTaskActivityBehavior.java
@@ -92,7 +92,7 @@ public void execute(CommandContext commandContext, PlanItemInstanceEntity planIt
             tenantId(planItemInstanceEntity.getTenantId());
 
         String fallBackToDefaultTenantValue = getFieldString(STRING_DECISION_TABLE_FALLBACK_TO_DEFAULT_TENANT);
-        if (fallBackToDefaultTenantValue != null && Boolean.parseBoolean(fallBackToDefaultTenantValue)) {
+        if (Boolean.parseBoolean(fallBackToDefaultTenantValue)) {
             executeDecisionBuilder.fallbackToDefaultTenant();
         }
 

diff --git a/modules/flowable-engine/src/main/java/org/flowable/engine/impl/cmd/AddCommentCmd.java b/modules/flowable-engine/src/main/java/org/flowable/engine/impl/cmd/AddCommentCmd.java
@@ -90,7 +90,7 @@ public Comment execute(CommandContext commandContext) {
             processDefinitionId = task.getProcessDefinitionId();
         }
 
-        if (processDefinitionId != null && Flowable5Util.isFlowable5ProcessDefinitionId(commandContext, processDefinitionId)) {
+        if (Flowable5Util.isFlowable5ProcessDefinitionId(commandContext, processDefinitionId)) {
             Flowable5CompatibilityHandler compatibilityHandler = Flowable5Util.getFlowable5CompatibilityHandler();
             return compatibilityHandler.addComment(taskId, processInstanceId, type, message);
         }