Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dependency check script #636

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add dependency check script #636

wants to merge 1 commit into from

Conversation

Kolloom
Copy link
Contributor

@Kolloom Kolloom commented Jul 16, 2019

Just wondering if this is a reasonable approach to check manim dependencies.

@eulertour
Copy link
Collaborator

This looks like a good start for both a --check-deps option as well as a test suite.

@Kolloom
Copy link
Contributor Author

Kolloom commented Jul 17, 2019

What is sox for? I did not find any calls to the program. I don't have sox installed on windows and manim seems running fine.

@Kolloom
Copy link
Contributor Author

Kolloom commented Jul 17, 2019

My attempt at obtaining a working virtual machine running macos has not been successful. I will not be implementing the macos portion of the script.

@eulertour
Copy link
Collaborator

@Kolloom the sox package contains the play binary which is run from manimlib/utils/sounds.py.

@Kolloom
Copy link
Contributor Author

Kolloom commented Jul 17, 2019

@eulertour seems sox is only used when --sound is set then? This dependency is optional? I haven't seem anyone use the flag in the wild.

@eulertour
Copy link
Collaborator

@Kolloom yeah it's only optional, it's left over from a long time ago.

Fix windows path
black format
add windows sox detection
add latex package check
stub for darwin
some formatting
sox windows detection fix
add code paths for different distros

fix error logic

add more diagnosis messages

fix python module detection

add debian variant diagnosis mesg

add other distro names
add macos path

add log read when latex fail

logic fix

add more mesg

add missing sox diagonosis for windwos

add another scipy module test

add mesg for demo scene when command fails

fix msg
@Kolloom Kolloom changed the title [WIP] add dependency check script add dependency check script Jul 20, 2019
@Kolloom
Copy link
Contributor Author

Kolloom commented Jul 20, 2019

patch ready for review

@k9ur
Copy link

k9ur commented Jul 17, 2022

Can you open a new fork, a couple issues with the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants