Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy RC 437 to Production #11614

Merged
merged 14 commits into from
Dec 10, 2024
Merged

Deploy RC 437 to Production #11614

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
290d909
Reload all AB tests after running AB test specs (#11583)
matthinz Dec 5, 2024
d461b1b
LG-15197: Omit policy_details_api from ThreatMetrix response body log…
aduth Dec 5, 2024
89afb54
LG-15121 Add a `post_idv_followup_url` configuration to service provi…
jmhooper Dec 5, 2024
078470c
Fix Face/Touch recommendation duplicate submission (#11608)
aduth Dec 6, 2024
3523bf5
Minor refactor of profile handling in EnterPasswordController (#11603)
matthinz Dec 6, 2024
769cd47
Update erb_lint to 0.7.0 (#11610)
matthinz Dec 6, 2024
18066d5
LG-14749 Cancel enrollments on profile encryption error (#11585)
shanechesnutt-ft Dec 6, 2024
5e8b9e8
LG-14972 | Fix XML fixture; implement match_xml matcher (#11599)
n1zyy Dec 6, 2024
31ed8e2
changelog: User-Facing Improvements, Integration Experience, Adding a…
Sgtpluck Dec 6, 2024
5b99b74
LG-15150: docv test mode (#11546)
amirbey Dec 6, 2024
9d7e3ea
Update report to use earlier event (#11570)
Sgtpluck Dec 9, 2024
27d822b
LG-14923 Update content for mobile required flow without facial match…
theabrad Dec 9, 2024
cd90fae
LG-15177 Add a CTA to return to an SP after entering a verify-by-mail…
jmhooper Dec 9, 2024
e44b47f
Lg-14279 document request analytics event (#11581)
AShukla-GSA Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor refactor of profile handling in EnterPasswordController (#11603) 
Return a Profile from Idv::Session::create_profile_from_applicant_with_password, then use that directly in EnterPasswordController.

[skip changelog]
  • Loading branch information
@matthinz
matthinz authored Dec 6, 2024
commit 3523bf5f301bdb2dc92abd01aae53a050cc6f862
7 changes: 4 additions & 3 deletions app/controllers/idv/enter_password_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ def confirm_current_password
end

def init_profile
idv_session.create_profile_from_applicant_with_password(
profile = idv_session.create_profile_from_applicant_with_password(
password,
is_enhanced_ipp: resolved_authn_context_result.enhanced_ipp?,
proofing_components: ProofingComponents.new(
Expand All @@ -137,12 +137,13 @@ def init_profile
user_session:,
).to_h,
)
if idv_session.verify_by_mail?

if profile.gpo_verification_pending?
current_user.send_email_to_all_addresses(:verify_by_mail_letter_requested)
log_letter_enqueued_analytics(resend: false)
end

if idv_session.profile.active?
if profile.active?
create_user_event(:account_verified)
UserAlerts::AlertUserAboutAccountVerified.call(
profile: idv_session.profile,
Expand Down
3 changes: 3 additions & 0 deletions app/services/idv/session.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ def respond_to_missing?(method_sym, include_private)
VALID_SESSION_ATTRIBUTES.include?(attr_name_sym) || super
end

# @return [Profile]
def create_profile_from_applicant_with_password(
user_password, is_enhanced_ipp:, proofing_components:
)
Expand Down Expand Up @@ -141,6 +142,8 @@ def create_profile_from_applicant_with_password(
if profile.gpo_verification_pending?
create_gpo_entry(profile_maker.pii_attributes, profile)
end

profile
end

def opt_in_param
Expand Down