Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save a draft version of feature settings #3720

Merged
merged 12 commits into from
Oct 24, 2023
Merged

Save a draft version of feature settings #3720

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b055536
Save a draft version of feature settings
felipeelia Oct 24, 2023
ea64a24
Front-end support for draft settings.
JakePT Oct 24, 2023
96c160f
Update features using the update_feature method
felipeelia Oct 24, 2023
3a20f4a
Setup features as soon as possible
felipeelia Oct 24, 2023
2c7ead7
Update draft using update_feature()
felipeelia Oct 24, 2023
cb1d680
Use the correct base of settings
felipeelia Oct 24, 2023
a74bf3a
Update feature in the right place
felipeelia Oct 24, 2023
d9d6ca4
Debug cypress tests
felipeelia Oct 24, 2023
9c978b9
Wait until the modal is visible
felipeelia Oct 24, 2023
d0e40bd
Set test back to original
felipeelia Oct 24, 2023
0d51d07
Delete draft option on uninstall and save setting if deactivating
felipeelia Oct 24, 2023
1f10c1c
Merge branch '5.0.0' into feat/tw-19354071
felipeelia Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Set test back to original
  • Loading branch information
@felipeelia
felipeelia committed Oct 24, 2023
commit d0e40bd97ca9d111a123d5bf9ee2c9e85d69f5ea
11 changes: 1 addition & 10 deletions tests/cypress/integration/features/instant-results.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,6 @@ describe('Instant Results Feature', { tags: '@slow' }, () => {
cy.get('.components-form-token-field__input').type(
'{backspace}{backspace}{backspace}price{downArrow}{enter}{esc}',
);

cy.screenshot('instant-results-facets');

cy.contains('button', 'Save changes').click();

cy.wait('@apiRequest');
Expand All @@ -243,14 +240,8 @@ describe('Instant Results Feature', { tags: '@slow' }, () => {
* Perform a search.
*/
cy.visit('/');

cy.get('.wp-block-search').last().as('searchBlock');
cy.get('@searchBlock').find('button').click();
cy.get('.ep-search-modal').should('be.visible');
cy.screenshot('instant-results-modal');
cy.get('body').type('{esc}');

cy.intercept('*search=ergonomic*').as('apiRequest');
cy.get('.wp-block-search').last().as('searchBlock');
cy.get('@searchBlock').find('input[type="search"]').type('ergonomic');
cy.get('@searchBlock').find('button').click();
cy.get('.ep-search-modal').should('be.visible');
Expand Down