Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated feature settings UI #3712

Merged
merged 31 commits into from
Oct 23, 2023
Merged

Updated feature settings UI #3712

Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
9d87563
Move feature dependencies to requires_feature.
JakePT Oct 18, 2023
fe83a41
Add full description to summary.
JakePT Oct 18, 2023
7919029
Move ElasticPress.io branding to is_epio property.
JakePT Oct 18, 2023
9d544fd
Include visibility in JSON data.
JakePT Oct 18, 2023
bc3fc51
Change property name.
JakePT Oct 18, 2023
b22ce91
Updated feature settings UI.
JakePT Oct 19, 2023
798bc80
Rename Features screen class.
JakePT Oct 19, 2023
d5ff620
Prevent saving settings when syncing.
JakePT Oct 19, 2023
446b211
Fix error with facet selector.
JakePT Oct 19, 2023
753669a
Merge branch '5.0.0' into feature/feature-settings-ui
JakePT Oct 19, 2023
0411db4
Update tests.
JakePT Oct 19, 2023
e323b51
Update unit tests.
JakePT Oct 19, 2023
a2fdcdb
Add requires_feature to tests.
JakePT Oct 19, 2023
9ca341b
Fix tests.
JakePT Oct 19, 2023
075f7aa
Update highlight setting type.
JakePT Oct 19, 2023
4e1d9fb
Add missing properties to test.
JakePT Oct 19, 2023
2a8878a
Test fixes.
JakePT Oct 19, 2023
c87c06d
Fix is_decaying_enabled check.
JakePT Oct 19, 2023
67af2ea
Remove test that is no longer relevant.
JakePT Oct 19, 2023
627308c
Update property for features screen.
JakePT Oct 19, 2023
58dcab6
Add missing text domain.
JakePT Oct 19, 2023
886609f
Fix documents test.
JakePT Oct 19, 2023
2ddda0c
Fix visibility check in availability check.
JakePT Oct 19, 2023
4d5b731
Fix orders autosuggest availability.
JakePT Oct 19, 2023
a79e80e
Allow HTML in requirements notices.
JakePT Oct 19, 2023
8d3f435
Require sync for orders autosuggest setting.
JakePT Oct 19, 2023
b730553
Fix error on invalid values for filter picker.
JakePT Oct 19, 2023
5e48784
Merge branch '5.0.0' into feature/feature-settings-ui
felipeelia Oct 23, 2023
f0037a0
Only call `set_settings_schema` when needed
felipeelia Oct 23, 2023
bc6e61d
Fix warnings and run post_activation
felipeelia Oct 23, 2023
3b3e348
Remove booleans by default
felipeelia Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update unit tests.
  • Loading branch information
@JakePT
JakePT committed Oct 19, 2023
commit e323b518197790f04ff4c808987b7dee29a0d547
8 changes: 4 additions & 4 deletions tests/php/TestFeature.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,14 @@ function() {
[
'default' => false,
'key' => 'active',
'label' => __( 'Enabled', 'elasticpress' ),
'label' => __( 'Enable', 'elasticpress' ),
'requires_sync' => false,
'type' => 'toggle',
],
],
];

$this->assertSame( wp_json_encode( $expected ), $stub->get_json() );
$this->assertSame( $expected, $stub->get_json() );
}

/**
Expand All @@ -81,7 +81,7 @@ public function test_get_settings_schema() {
[
'default' => false,
'key' => 'active',
'label' => __( 'Enabled', 'elasticpress' ),
'label' => __( 'Enable', 'elasticpress' ),
'requires_sync' => false,
'type' => 'toggle',
],
Expand Down Expand Up @@ -115,7 +115,7 @@ public function test_ep_feature_settings_schema_filter() {
[
'default' => false,
'key' => 'active',
'label' => __( 'Enabled', 'elasticpress' ),
'label' => __( 'Enable', 'elasticpress' ),
'requires_sync' => false,
'type' => 'toggle',
],
Expand Down
Loading