Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Features to declare settings as JSON #3655

Merged
merged 7 commits into from
Sep 27, 2023
Merged

Update Features to declare settings as JSON #3655

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
361b16c
Settings schema
felipeelia Sep 26, 2023
c105e34
Several fixes
felipeelia Sep 27, 2023
06ab428
Adjust tests
felipeelia Sep 27, 2023
302daa3
Add options to decay when WC is enabled
felipeelia Sep 27, 2023
f23b3ea
Adjust test
felipeelia Sep 27, 2023
cdb0ad5
Fix test (again)
felipeelia Sep 27, 2023
c9c5525
editable => readonly
felipeelia Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
editable => readonly
  • Loading branch information
@felipeelia
felipeelia committed Sep 27, 2023
commit c9c5525bf85a84e42673f45673f31b9c8cb7492c
2 changes: 1 addition & 1 deletion includes/classes/Feature/WooCommerce/WooCommerce.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ protected function set_settings_schema() {
$this->settings_schema = [
[
'default' => '0',
'editable' => ! $available,
'readonly' => ! $available,
'help' => $message,
'key' => 'orders',
'label' => __( 'Orders Autosuggest', 'elasticpress' ),
Expand Down