Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facet by post type #3473

Merged
merged 11 commits into from
Jun 5, 2023
Merged

Facet by post type #3473

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f943258
Facet by post type
oscarssanchez May 26, 2023
093c83d
Return filter variable
oscarssanchez May 29, 2023
73e093b
Merge branch 'develop' into feature/facet-post-type-ir
oscarssanchez May 29, 2023
c853324
Add Renderer Unit test
oscarssanchez May 30, 2023
18d277e
Merge branch 'feature/facet-post-type-ir' of github.com:10up/ElasticP…
oscarssanchez May 30, 2023
ab449e1
General adjustments
felipeelia Jun 2, 2023
fbefbb5
Unit tests + query param change
felipeelia Jun 2, 2023
1c14cd4
Remove the facet parameter and add e2e tests
felipeelia Jun 2, 2023
d4de7e9
Merge branch 'develop' into feature/facet-post-type-ir
felipeelia Jun 5, 2023
81cc037
Filter names + docs
felipeelia Jun 5, 2023
4736046
Fix indentation
felipeelia Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix indentation
  • Loading branch information
@felipeelia
felipeelia committed Jun 5, 2023
commit 4736046fb47ba0ee6b38d465678e93bbae35efe0
2 changes: 1 addition & 1 deletion includes/classes/Feature/Facets/Types/PostType/Renderer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ public function get_post_type_value_html( $value, $url ) : string {
* performed by visiting the link, such as whether the filter will be
* added or removed.
*
* @since 4.6.0
* @since 4.6.0
* @hook ep_facet_post_type_value_accessible_label
* @param {string} $label Facet post-type value accessible label.
* @param {array} $value Value array. It contains `value`, `name`, `count`, and `is_selected`.
Expand Down