Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle expired or missing tokens for orders autosuggest #3308

Merged
merged 12 commits into from
Feb 15, 2023
Merged

Handle expired or missing tokens for orders autosuggest #3308

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ae02f07
WIP: Handle expiring tokens.
JakePT Feb 7, 2023
db7efbb
Handle expired or invalid tokens.
JakePT Feb 9, 2023
9bba55f
Support open in new tab with Ctrl/Cmd+Click/Enter.
JakePT Feb 9, 2023
136c359
Fix incorrect dates and times.
JakePT Feb 9, 2023
f5f7f7c
Close listbox immediately on empty.
JakePT Feb 9, 2023
5168fd1
Merge branch 'develop' into feature/3296
felipeelia Feb 14, 2023
a54f85e
add a trailing slash to EP.io host
felipeelia Feb 14, 2023
367cb13
Fix typo
felipeelia Feb 14, 2023
0684c76
Fix looping requests on non-authentication related errors.
JakePT Feb 15, 2023
68bbe25
Disable browser autocomplete for orders search box.
JakePT Feb 15, 2023
a28909a
Merge branch 'develop' into feature/3296
JakePT Feb 15, 2023
5350509
Merge branch 'develop' into feature/3296
felipeelia Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix looping requests on non-authentication related errors.
  • Loading branch information
@JakePT
JakePT committed Feb 15, 2023
commit 0684c767e63a0c552791fe2fb52cc38771ea04e5
18 changes: 11 additions & 7 deletions assets/js/woocommerce/admin/orders/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* WordPress dependencies.
*/
import { render, useEffect, useState, WPElement } from '@wordpress/element';
import { render, useEffect, useRef, useState, WPElement } from '@wordpress/element';

/**
* Internal dependencies.
Expand Down Expand Up @@ -32,15 +32,19 @@ const AuthenticatedApiSearchProvider = ({ children }) => {
* State.
*/
const [credentials, setCredentials] = useState(null);
const [hasRefreshed, setHasRefreshed] = useState(false);

/**
* Refs.
*/
const hasRefreshed = useRef(false);

/**
* Refresh credentials on authentication errors.
*
* @returns {void}
*/
const onAuthError = () => {
if (hasRefreshed) {
if (hasRefreshed.current) {
setCredentials(null);
return;
}
Expand All @@ -52,7 +56,7 @@ const AuthenticatedApiSearchProvider = ({ children }) => {
.then((response) => response.text())
.then(setCredentials);

setHasRefreshed(true);
hasRefreshed.current = true;
};

/**
Expand All @@ -76,7 +80,7 @@ const AuthenticatedApiSearchProvider = ({ children }) => {
/**
* Render.
*/
return (
return credentials ? (
<ApiSearchProvider
apiEndpoint={apiEndpoint}
apiHost={apiHost}
Expand All @@ -85,9 +89,9 @@ const AuthenticatedApiSearchProvider = ({ children }) => {
requestIdBase={requestIdBase}
onAuthError={onAuthError}
>
{credentials ? children : null}
{children}
</ApiSearchProvider>
);
) : null;
};

/**
Expand Down