Update: This commit fixes lint issues. Additionally, this adds fail-f…

…ast as false in cypress test matrix to avoid job cancellation incase of parallel job failure
10up · felipeelia · Jan 27, 2023 · Dec 5, 2022 · Dec 5, 2022 · Dec 5, 2022
commit 8304594c0b3919f53144734a6cc3078e63efc3d1
diff --git a/.github/workflows/cypress-tests.yml b/.github/workflows/cypress-tests.yml
@@ -21,6 +21,7 @@ jobs:
     name: Cypress - Local
     runs-on: ubuntu-latest
     strategy:
+      fail-fast: false
       matrix:
         testGroup: ['@slow', '-@slow']
 
@@ -75,6 +76,7 @@ jobs:
     name: Cypress - EP.io
     runs-on: ubuntu-latest
     strategy:
+      fail-fast: false
       matrix:
         testGroup: ['@slow', '-@slow']
 

diff --git a/tests/cypress/integration/features/comments.cy.js b/tests/cypress/integration/features/comments.cy.js
@@ -1,3 +1,4 @@
+// eslint-disable-next-line jest/valid-describe-callback
 describe('Comments Feature', { tags: '@slow' }, () => {
 	const defaultApprovedComments = 26;
 

diff --git a/tests/cypress/integration/features/facets.cy.js b/tests/cypress/integration/features/facets.cy.js
@@ -1,3 +1,4 @@
+// eslint-disable-next-line jest/valid-describe-callback
 describe('Facets Feature', { tags: '@slow' }, () => {
 	/**
 	 * Ensure the feature is active, perform a sync, and remove test posts

diff --git a/tests/cypress/integration/features/instant-results.cy.js b/tests/cypress/integration/features/instant-results.cy.js
@@ -1,5 +1,6 @@
 /* global isEpIo */
 
+// eslint-disable-next-line jest/valid-describe-callback
 describe('Instant Results Feature', { tags: '@slow' }, () => {
 	/**
 	 * Create a Search widget.

diff --git a/tests/cypress/integration/features/search/search.cy.js b/tests/cypress/integration/features/search/search.cy.js
@@ -1,3 +1,4 @@
+// eslint-disable-next-line jest/valid-describe-callback
 describe('Post Search Feature', { tags: '@slow' }, () => {
 	before(() => {
 		cy.wpCli('elasticpress sync --setup --yes');

diff --git a/tests/cypress/integration/features/terms.cy.js b/tests/cypress/integration/features/terms.cy.js
@@ -1,3 +1,4 @@
+// eslint-disable-next-line jest/valid-describe-callback
 describe('Terms Feature', { tags: '@slow' }, () => {
 	const tags = ['Far From Home', 'No Way Home', 'The Most Fun Thing'];
 

diff --git a/tests/cypress/integration/features/woocommerce.cy.js b/tests/cypress/integration/features/woocommerce.cy.js
@@ -1,3 +1,4 @@
+// eslint-disable-next-line jest/valid-describe-callback
 describe('WooCommerce Feature', { tags: '@slow' }, () => {
 	const userData = {
 		username: 'testuser',

diff --git a/tests/cypress/integration/general.cy.js b/tests/cypress/integration/general.cy.js
@@ -1,3 +1,4 @@
+// eslint-disable-next-line jest/valid-describe-callback
 describe('WordPress can perform standard ElasticPress actions', { tags: '@slow' }, () => {
 	it('Can see the settings page link in WordPress Dashboard', () => {
 		cy.login();

diff --git a/tests/cypress/integration/wp-cli.cy.js b/tests/cypress/integration/wp-cli.cy.js
@@ -1,5 +1,6 @@
 /* global indexNames */
 
+// eslint-disable-next-line jest/valid-describe-callback
 describe('WP-CLI Commands', { tags: '@slow' }, () => {
 	let indexAllSitesNames = [];
 

diff --git a/tests/cypress/support/index.js b/tests/cypress/support/index.js
@@ -20,6 +20,7 @@ import './global-hooks';
 
 // Import cypress grep
 import registerCypressGrep from '@cypress/grep';
+
 registerCypressGrep();
 
 // Alternatively you can use CommonJS syntax: