Cleanup Autosuggest description and change title for autosuggest and instant results #3207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeelia
requested changes
Dec 16, 2022
There was a problem hiding this comment.
@burhandodhy in addition to my comments below, there is also a visual problem we will need to address. This is how I'm seeing it in my local:
JakePT
requested changes
Dec 19, 2022
JakePT
requested changes
Dec 21, 2022
JakePT
previously approved these changes
Dec 21, 2022
felipeelia
requested changes
Dec 22, 2022
There was a problem hiding this comment.
@burhandodhy some last changes before we merge it. Also, I don't know if it is something in my computer but the logo looks "pixelated" to me here (see below.) Even the full-size svg looks a bit pixelated to me.
felipeelia
requested changes
Jan 4, 2023
| '</a>', | ||
| '<a href="' . esc_url( $epio_autosuggest_kb_link ) . '">', | ||
| '</a>', | ||
| '<a href="' . esc_url( admin_url( 'site-health.php?tab=debug' ) ) . '">', |
There was a problem hiding this comment.
@burhandodhy can you please change this link to point to the Status Report page? Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR updates the titles for the Autosuggest and Instant Results feature if the ElasticPress is connected with ep.io. Also it removed the old checks from the autosuggest description.
Closes #3191
How to test the Change
Changelog Entry
Credits
Props @burhandodhy @felipeelia @NV607FOX
Checklist: