Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply facets filters directly into the ES query and support and/or across different facet types #3045

Merged
merged 14 commits into from
Oct 17, 2022
Merged

Apply facets filters directly into the ES query and support and/or across different facet types #3045

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8807277
Apply facet filters directly into the ES query
felipeelia Oct 4, 2022
f711735
Facets: If 'any', remove 'facets' filters from agg
felipeelia Oct 4, 2022
3d6ab33
Remove tests for removed methods
felipeelia Oct 4, 2022
3f3b0ce
If any filter is selected, do not display sticky posts
felipeelia Oct 5, 2022
732759c
Wait for the preview
felipeelia Oct 5, 2022
1cfadd7
Fix check of empty facet filters
felipeelia Oct 5, 2022
d73934e
Wait for the exact request
felipeelia Oct 5, 2022
49d9dcc
Wait for the correct request before checking order
felipeelia Oct 5, 2022
a188e16
Merge branch 'develop' into feature/issue-2970
felipeelia Oct 12, 2022
626dc87
Merge branch 'develop' into feature/issue-2970
felipeelia Oct 12, 2022
0044e79
Add _doing_it_wrong calls
felipeelia Oct 12, 2022
e411dab
New ep_facet_match_type filter + docs
felipeelia Oct 12, 2022
925002f
Some unit tests
felipeelia Oct 12, 2022
42efcd6
E2e test to check Facet match type
felipeelia Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
If any filter is selected, do not display sticky posts
  • Loading branch information
@felipeelia
felipeelia committed Oct 5, 2022
commit 3f3b0ce3328cb14dace523dd873dcdd6f93b65d0
6 changes: 6 additions & 0 deletions includes/classes/Feature/Facets/Facets.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,12 @@ public function facet_query( $query ) {
return;
}

// If any filter was selected, there is no reason to prepend the list with sticky posts.
$selected_filters = $this->get_selected();
if ( ! empty( $selected_filters ) ) {
$query->set( 'ignore_sticky_posts', true );
}

/**
* Filter facet aggregations.
*
Expand Down