Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add history and shareable URLs support to Instant Results #2604

Merged
merged 15 commits into from
Feb 25, 2022
Merged

Add history and shareable URLs support to Instant Results #2604

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
fe742b0
Simplify filters state.
JakePT Feb 8, 2022
bb17033
Support history API for navigating modal.
JakePT Feb 17, 2022
525ff1c
Support opening the modal with pre-defined args if they are found in …
JakePT Feb 22, 2022
edc25b2
Merge branch '4.x.x' into feature/2506
JakePT Feb 22, 2022
b1eb623
Support post_type arg regardless of whether facet is present.
JakePT Feb 23, 2022
3d6f2a5
Merge branch '4.x.x' into feature/2506
JakePT Feb 24, 2022
c8ee305
Fix JSDoc related linting warnings.
JakePT Feb 24, 2022
ca15007
Merge branch '4.x.x' into feature/2506
JakePT Feb 25, 2022
4a21aa0
Fixed an issue caused by incorrect or outdated facet keys.
JakePT Feb 25, 2022
482a046
Add missing key. Fixes crash in debug mode.
JakePT Feb 25, 2022
f5e0e52
Memoize context value. Fixes linting value.
JakePT Feb 25, 2022
bcdd0fc
Move Show All button into render function. Fixes linting error.
JakePT Feb 25, 2022
8d000ae
Replace empty Fragment with null. Fixes linting error.
JakePT Feb 25, 2022
99ceb85
Fix search input not changing on popped state.
JakePT Feb 25, 2022
339e520
Remove unused property defintition. Fixes linting error.
JakePT Feb 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add missing key. Fixes crash in debug mode.
  • Loading branch information
@JakePT
JakePT committed Feb 25, 2022
commit 482a046eaebc898f583db0cfa5e32149e910a5a6
15 changes: 11 additions & 4 deletions assets/js/instant-results/components/layout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import Sort from './tools/sort';
*/
export default () => {
const {
state: { isLoading, isSidebarOpen },
state: { isLoading },
} = useContext(Context);

return (
Expand All @@ -41,10 +41,17 @@ export default () => {
</div>

<div className="ep-search-page__body">
<Sidebar isOpen={isSidebarOpen}>
<Sidebar>
<Sort />
{facets.map((facet, index) => (
<Facet {...facet} index={index} />
{facets.map(({ label, name, postTypes, type }, index) => (
<Facet
index={index}
key={name}
label={label}
name={name}
postTypes={postTypes}
type={type}
/>
))}
</Sidebar>

Expand Down