Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Indexing (for 4.0) #2585

Merged
merged 7 commits into from
Mar 4, 2022
Merged

Dynamic Indexing (for 4.0) #2585

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c7044ef
Add a method to bulk index docs with a dynamic size of queue
felipeelia Feb 4, 2022
7b38323
Reduce the attempts for WP-CLI to one
felipeelia Feb 28, 2022
1395043
Another version of send_bulk_index_request
felipeelia Feb 28, 2022
603f9aa
Merge branch '4.x.x' into feature/dynamic-indexing-4.x.x
felipeelia Feb 28, 2022
4054154
Merge branch 'develop' into feature/dynamic-indexing-4.x.x
felipeelia Mar 4, 2022
61c6d77
Remove error_log calls and add hooks
felipeelia Mar 4, 2022
78298d1
Add an option to use static bulk (the opposite of dynamic bulk)
felipeelia Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add an option to use static bulk (the opposite of dynamic bulk)
  • Loading branch information
@felipeelia
felipeelia committed Mar 4, 2022
commit 78298d10b8193ebbfeadaee6479cc14007faec47
4 changes: 4 additions & 0 deletions includes/classes/Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,6 +646,9 @@ public function delete_transient_on_int( $signal_no ) {
* [--nobulk]
* : Disable bulk indexing
*
* [--static-bulk]
* : Do not use dynamic bulk requests, i.e., send only one request per batch of documents.
*
* [--show-errors]
* : Show all errors
*
Expand Down Expand Up @@ -748,6 +751,7 @@ public function index( $args, $assoc_args ) {
'network_wide' => ( ! empty( $assoc_args['network-wide'] ) ) ? $assoc_args['network-wide'] : null,
'nobulk' => $no_bulk,
'offset' => ( ! empty( $assoc_args['offset'] ) ) ? absint( $assoc_args['offset'] ) : 0,
'static_bulk' => ( ! empty( $assoc_args['static-bulk'] ) ) ? $assoc_args['static-bulk'] : null,
];

if ( isset( $assoc_args['show-errors'] ) || ( isset( $assoc_args['show-bulk-errors'] ) && ! $no_bulk ) || ( isset( $assoc_args['show-nobulk-errors'] ) && $no_bulk ) ) {
Expand Down
6 changes: 5 additions & 1 deletion includes/classes/IndexHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,11 @@ protected function index_next_batch() {
$should_retry = true;
}
} else {
$bulk_requests = $indexable->bulk_index_dynamically( $queued_items_ids );
if ( ! empty( $this->args['static_bulk'] ) ) {
$bulk_requests = [ $indexable->bulk_index( $queued_items_ids ) ];
} else {
$bulk_requests = $indexable->bulk_index_dynamically( $queued_items_ids );
}

$failed_objects = [];
foreach ( $bulk_requests as $return ) {
Expand Down