Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post__name_in support #2194

Merged
merged 7 commits into from
May 21, 2021
Merged

Add post__name_in support #2194

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3adfda7
Add post__name_in support
May 4, 2021
6d55f18
Fix linting issues
May 4, 2021
55521a9
Merge branch 'develop' into feature/post__name_in-support
May 5, 2021
3c58949
Wrap arg with array_values
May 13, 2021
0e42db1
Change term query for terms
May 13, 2021
04e136a
Add tests for array post_name__in scenario
May 20, 2021
99d4a2e
Merge branch 'develop' into feature/post__name_in-support
May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions includes/classes/Indexable/Post/Post.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,6 +870,21 @@ function( $tax_query ) use ( $args ) {
$use_filters = true;
}

/**
* 'post_name__in' arg support.
*
* @since 3.6.0
*/
if ( ! empty( $args['post_name__in'] ) ) {
$filter['bool']['must'][]['bool']['must'] = array(
'terms' => array(
'post_name.raw' => array_values( (array) $args['post_name__in'] ),
),
);

$use_filters = true;
}

/**
* 'post__not_in' arg support.
*
Expand Down
29 changes: 29 additions & 0 deletions tests/php/indexables/TestPost.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3682,6 +3682,35 @@ public function testPostParentQuery() {
$this->assertEquals( 1, $query->found_posts );
}

/**
* Test a post_name__in query
*
* @group post
* @since 3.6.0
*/
public function testPostNameInQuery() {
Functions\create_and_sync_post(
array(
'post_content' => 'findme name in test 1',
'post_name' => 'findme-name-in',
)
);
Functions\create_and_sync_post( array( 'post_content' => 'findme name in test 2' ) );
Functions\create_and_sync_post( array( 'post_content' => 'findme name in test 3' ) );

ElasticPress\Elasticsearch::factory()->refresh_indices();

$args = array(
's' => 'findme name in',
'post_name__in' => 'findme-name-in',
Rahmon marked this conversation as resolved.
Show resolved Hide resolved
);

$query = new \WP_Query( $args );

$this->assertEquals( 1, $query->post_count );
$this->assertEquals( 1, $query->found_posts );
}

/**
* Test Tax Query NOT IN operator
*
Expand Down