Skip to content

Commit

Permalink
Remove non-standard getTransformToElement from SVGGraphicsElement
Browse files Browse the repository at this point in the history 
https://bugs.webkit.org/show_bug.cgi?id=268427
rdar://problem/122435702

Reviewed by Said Abou-Hallawa.

This patch aligns WebKit with Gecko / Firefox, Blink / Chromium
and web specification [1] by removing this non-standard:

[1] https://lists.w3.org/Archives/Public/www-svg/2015Aug/att-0009/SVGWG-F2F-minutes-20150824.html#item02

This was removed from Blink in 2015 and also not supported in Gecko.

* Source/WebCore/svg/SVGGraphicsElement.idl:
* Source/WebCore/svg/SVGLocatable.cpp:
(WebCore::SVGLocatable::getTransformToElement): Deleted.
* Source/WebCore/svg/SVGLocatable.h:
* LayoutTests/platform/glib/svg/custom/getTransformToElement-expected.txt: Removed.
* LayoutTests/platform/gtk/svg/custom/getTransformToElement-expected.png: Removed.
* LayoutTests/platform/ios/svg/custom/getTransformToElement-expected.txt: Removed.
* LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/getTransformToElement-expected.txt: Removed.
* LayoutTests/platform/mac-sonoma-wk2-pixel/svg/custom/getTransformToElement-expected.png: Removed.
* LayoutTests/platform/mac/svg/custom/getTransformToElement-expected.png: Removed.
* LayoutTests/platform/mac/svg/custom/getTransformToElement-expected.txt: Removed.
* LayoutTests/platform/wincairo/svg/custom/getTransformToElement-expected.txt: Removed.
* LayoutTests/svg/W3C-SVG-1.1/types-basicDOM-01-b.svg:
* LayoutTests/svg/animations/animate-elem-04-t-drt.html:
* LayoutTests/svg/animations/animate-elem-05-t-drt.html:
* LayoutTests/svg/animations/animate-elem-06-t-drt.html:
* LayoutTests/svg/animations/animate-elem-07-t-drt.html:
* LayoutTests/svg/animations/animate-elem-08-t-drt.html:
* LayoutTests/svg/animations/animate-elem-09-t-drt.html:
* LayoutTests/svg/animations/animate-elem-10-t-drt.html:
* LayoutTests/svg/animations/animate-elem-11-t-drt.html:
* LayoutTests/svg/animations/animate-elem-12-t-drt.html:
* LayoutTests/svg/animations/animateTransform-translate-attributetype-auto.html:
* LayoutTests/svg/animations/animateTransform-translate-invalid-attributetype.html:
* LayoutTests/svg/animations/resources/SVGAnimationTestCase.js:
(getTransformToElement):
* LayoutTests/svg/custom/get-text-element-transform-crash-expected.txt: Removed.
* LayoutTests/svg/custom/get-text-element-transform-crash.html: Removed.
* LayoutTests/svg/custom/getTransformToElement.svg: Removed.
* LayoutTests/svg/dom/css-transforms.xhtml:
* LayoutTests/svg/text/selection-tripleclick.svg:
* LayoutTests/imported/w3c/web-platform-tests/svg/historical-expected.txt:
* LayoutTests/svg/animations/animate-elem-04-t-drt-expected.txt:
* LayoutTests/svg/animations/animate-elem-05-t-drt-expected.txt:
* LayoutTests/svg/animations/animate-elem-06-t-drt-expected.txt:
* LayoutTests/svg/animations/animate-elem-07-t-drt-expected.txt:
* LayoutTests/svg/animations/animate-elem-08-t-drt-expected.txt:
* LayoutTests/svg/animations/animate-elem-09-t-drt-expected.txt:
* LayoutTests/svg/animations/animate-elem-10-t-drt-expected.txt:
* LayoutTests/svg/animations/animate-elem-11-t-drt-expected.txt:
* LayoutTests/svg/animations/animate-elem-12-t-drt-expected.txt:
* LayoutTests/svg/animations/animateTransform-translate-attributetype-auto-expected.txt:
* LayoutTests/svg/animations/animateTransform-translate-invalid-attributetype-expected.txt:
* LayoutTests/svg/dom/css-transforms-expected.txt:
* LayoutTests/platform/gtk/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt:
* LayoutTests/platform/mac/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt:
* LayoutTests/platform/wpe/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt:
* LayoutTests/svg/custom/webkit-transform-crash.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/import/types-dom-01-b-manual.svg: Aligned with upstream
* LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/types-dom-01-b-manual-expected.txt: Rebaselined
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/types-dom-01-b-manual-expected.txt: Rebaselined
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/svg/import/types-dom-01-b-manual-expected.txt: Rebaselined
* LayoutTests/platform/ios/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt: Rebaselined

Canonical link: https://commits.webkit.org/280208@main
  • Loading branch information
Ahmad Saleem committed Jun 20, 2024
1 parent 03d1426 commit f1cd15a
Show file tree
Hide file tree
Showing 51 changed files with 276 additions and 445 deletions.
2 changes: 1 addition & 1 deletion LayoutTests/imported/w3c/web-platform-tests/svg/historical-expected.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ PASS SVGElement.prototype.getPresentationAttribute must be removed
PASS SVGElement.prototype.xmlbase must be removed
PASS SVGElement.prototype.xmllang must be removed
PASS SVGElement.prototype.xmlspace must be removed
FAIL SVGGraphicsElement.prototype.getTransformToElement must be removed assert_false: expected false got true
PASS SVGGraphicsElement.prototype.getTransformToElement must be removed
FAIL SVGGraphicsElement.prototype.hasExtension must be removed assert_false: expected false got true
FAIL SVGGraphicsElement.prototype.requiredFeatures must be removed assert_false: expected false got true
FAIL SVGSVGElement.prototype.currentView must be removed assert_false: expected false got true
Expand Down
14 changes: 4 additions & 10 deletions LayoutTests/imported/w3c/web-platform-tests/svg/import/types-dom-01-b-manual.svg
View file
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
19 changes: 8 additions & 11 deletions ...atform/glib/imported/w3c/web-platform-tests/svg/import/types-dom-01-b-manual-expected.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ layer at (0,0) size 800x600
layer at (0,0) size 800x600
RenderSVGRoot {svg} at (0,0) size 800x600
RenderSVGHiddenContainer {defs} at (0,0) size 0x0
RenderSVGContainer {g} at (16,14) size 609x491
RenderSVGContainer {g} at (16,14) size 609x491
RenderSVGContainer {g} at (16,14) size 609x457
RenderSVGContainer {g} at (16,14) size 609x457
RenderSVGContainer {g} at (28,14) size 597x258 [transform={m=((1.00,0.00)(0.00,1.00)) t=(70.00,-60.00)}]
RenderSVGText {text} at (30,132) size 342x22 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 342x22
Expand All @@ -20,18 +20,15 @@ layer at (0,0) size 800x600
RenderSVGText {text} at (10,209) size 255x14 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 255x14
chunk 1 text run 1 at (10.00,220.00) startOffset 0 endOffset 46 width 254.11: ".getCTM(): 0.71,0.71,-0.71,0.71,116.67,-100.00"
RenderSVGText {text} at (10,229) size 310x14 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 310x14
chunk 1 text run 1 at (10.00,240.00) startOffset 0 endOffset 56 width 309.62: ".getTransformToElement(): 0.42,0.42,-0.42,0.42,0.00,0.00"
RenderSVGText {text} at (10,249) size 344x14 contains 1 chunk(s)
RenderSVGText {text} at (10,229) size 344x14 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 344x14
chunk 1 text run 1 at (10.00,260.00) startOffset 0 endOffset 65 width 343.20: ".getBBox() for 'blueCircle': .x=-50,.y=-50,.width=100,.height=100"
RenderSVGText {text} at (10,269) size 255x14 contains 1 chunk(s)
chunk 1 text run 1 at (10.00,240.00) startOffset 0 endOffset 65 width 343.20: ".getBBox() for 'blueCircle': .x=-50,.y=-50,.width=100,.height=100"
RenderSVGText {text} at (10,249) size 255x14 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 255x14
chunk 1 text run 1 at (10.00,280.00) startOffset 0 endOffset 47 width 254.78: ".farthestViewportElement of blueCircle=svg-root"
RenderSVGText {text} at (10,289) size 272x14 contains 1 chunk(s)
chunk 1 text run 1 at (10.00,260.00) startOffset 0 endOffset 47 width 254.78: ".farthestViewportElement of blueCircle=svg-root"
RenderSVGText {text} at (10,269) size 272x14 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 272x14
chunk 1 text run 1 at (10.00,300.00) startOffset 0 endOffset 47 width 271.58: ".nearestViewportElement of blueCircle=nestedSVG"
chunk 1 text run 1 at (10.00,280.00) startOffset 0 endOffset 47 width 271.58: ".nearestViewportElement of blueCircle=nestedSVG"
RenderSVGContainer {g} at (16,518) size 388x60
RenderSVGText {text} at (10,311) size 233x36 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 233x36
Expand Down
11 changes: 0 additions & 11 deletions LayoutTests/platform/glib/svg/custom/getTransformToElement-expected.txt
View file

This file was deleted.

19 changes: 8 additions & 11 deletions LayoutTests/platform/gtk/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ layer at (0,0) size 480x360
RenderView at (0,0) size 480x360
layer at (0,0) size 480x360
RenderSVGRoot {svg} at (0,0) size 480x360
RenderSVGContainer {g} at (10,8) size 365x295
RenderSVGContainer {g} at (10,8) size 365x295
RenderSVGContainer {g} at (10,8) size 365x275
RenderSVGContainer {g} at (10,8) size 365x275
RenderSVGContainer {g} at (16,8) size 359x156 [transform={m=((1.00,0.00)(0.00,1.00)) t=(70.00,-60.00)}]
RenderSVGText {text} at (30,131) size 343x24 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 343x24
Expand All @@ -19,18 +19,15 @@ layer at (0,0) size 480x360
RenderSVGText {text} at (10,209) size 241x14 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 241x14
chunk 1 text run 1 at (10.00,220.00) startOffset 0 endOffset 44 width 241.00: ".getCTM(): 0.42,0.42,-0.42,0.42,70.00,-60.00"
RenderSVGText {text} at (10,229) size 310x14 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 310x14
chunk 1 text run 1 at (10.00,240.00) startOffset 0 endOffset 56 width 309.22: ".getTransformToElement(): 0.42,0.42,-0.42,0.42,0.00,0.00"
RenderSVGText {text} at (10,249) size 339x14 contains 1 chunk(s)
RenderSVGText {text} at (10,229) size 339x14 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 339x14
chunk 1 text run 1 at (10.00,260.00) startOffset 0 endOffset 64 width 339.00: ".getBBox() for 'redCircle': .x=-50,.y=-50,.width=100,.height=100"
RenderSVGText {text} at (10,269) size 253x14 contains 1 chunk(s)
chunk 1 text run 1 at (10.00,240.00) startOffset 0 endOffset 64 width 339.00: ".getBBox() for 'redCircle': .x=-50,.y=-50,.width=100,.height=100"
RenderSVGText {text} at (10,249) size 253x14 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 253x14
chunk 1 text run 1 at (10.00,280.00) startOffset 0 endOffset 46 width 252.78: ".farthestViewportElement of redCircle=svg-root"
RenderSVGText {text} at (10,289) size 272x14 contains 1 chunk(s)
chunk 1 text run 1 at (10.00,260.00) startOffset 0 endOffset 46 width 252.78: ".farthestViewportElement of redCircle=svg-root"
RenderSVGText {text} at (10,269) size 272x14 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 272x14
chunk 1 text run 1 at (10.00,300.00) startOffset 0 endOffset 46 width 271.78: ".nearestViewportElement of redCircle=nestedSVG"
chunk 1 text run 1 at (10.00,280.00) startOffset 0 endOffset 46 width 271.78: ".nearestViewportElement of redCircle=nestedSVG"
RenderSVGText {text} at (10,304) size 264x45 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 264x45
chunk 1 text run 1 at (10.00,340.00) startOffset 0 endOffset 16 width 264.00: "$Revision: 1.1 $"
Expand Down
Binary file removed LayoutTests/platform/gtk/svg/custom/getTransformToElement-expected.png
View file
Binary file not shown.
19 changes: 8 additions & 11 deletions ...latform/ios/imported/w3c/web-platform-tests/svg/import/types-dom-01-b-manual-expected.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ layer at (0,0) size 800x600
layer at (0,0) size 800x600
RenderSVGRoot {svg} at (0,0) size 800x600
RenderSVGHiddenContainer {defs} at (0,0) size 0x0
RenderSVGContainer {g} at (16,13) size 609x492
RenderSVGContainer {g} at (16,13) size 609x492
RenderSVGContainer {g} at (16,13) size 609x459
RenderSVGContainer {g} at (16,13) size 609x459
RenderSVGContainer {g} at (28,13) size 597x260 [transform={m=((1.00,0.00)(0.00,1.00)) t=(70.00,-60.00)}]
RenderSVGText {text} at (30,131) size 343x24 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 343x24
Expand All @@ -20,18 +20,15 @@ layer at (0,0) size 800x600
RenderSVGText {text} at (10,208) size 253x15 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 253x15
chunk 1 text run 1 at (10.00,220.00) startOffset 0 endOffset 46 width 252.16: ".getCTM(): 0.71,0.71,-0.71,0.71,116.67,-100.00"
RenderSVGText {text} at (10,228) size 309x15 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 309x15
chunk 1 text run 1 at (10.00,240.00) startOffset 0 endOffset 56 width 308.17: ".getTransformToElement(): 0.42,0.42,-0.42,0.42,0.00,0.00"
RenderSVGText {text} at (10,248) size 341x15 contains 1 chunk(s)
RenderSVGText {text} at (10,228) size 341x15 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 341x15
chunk 1 text run 1 at (10.00,260.00) startOffset 0 endOffset 65 width 340.78: ".getBBox() for 'blueCircle': .x=-50,.y=-50,.width=100,.height=100"
RenderSVGText {text} at (10,268) size 255x15 contains 1 chunk(s)
chunk 1 text run 1 at (10.00,240.00) startOffset 0 endOffset 65 width 340.78: ".getBBox() for 'blueCircle': .x=-50,.y=-50,.width=100,.height=100"
RenderSVGText {text} at (10,248) size 255x15 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 255x15
chunk 1 text run 1 at (10.00,280.00) startOffset 0 endOffset 47 width 254.45: ".farthestViewportElement of blueCircle=svg-root"
RenderSVGText {text} at (10,288) size 273x15 contains 1 chunk(s)
chunk 1 text run 1 at (10.00,260.00) startOffset 0 endOffset 47 width 254.45: ".farthestViewportElement of blueCircle=svg-root"
RenderSVGText {text} at (10,268) size 273x15 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 273x15
chunk 1 text run 1 at (10.00,300.00) startOffset 0 endOffset 47 width 272.48: ".nearestViewportElement of blueCircle=nestedSVG"
chunk 1 text run 1 at (10.00,280.00) startOffset 0 endOffset 47 width 272.48: ".nearestViewportElement of blueCircle=nestedSVG"
RenderSVGContainer {g} at (16,516) size 384x64
RenderSVGText {text} at (10,310) size 230x38 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 230x38
Expand Down
19 changes: 8 additions & 11 deletions LayoutTests/platform/ios/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ layer at (0,0) size 480x360
RenderView at (0,0) size 480x360
layer at (0,0) size 480x360
RenderSVGRoot {svg} at (0,0) size 480x360
RenderSVGContainer {g} at (10,8) size 365x295
RenderSVGContainer {g} at (10,8) size 365x295
RenderSVGContainer {g} at (10,8) size 365x275
RenderSVGContainer {g} at (10,8) size 365x275
RenderSVGContainer {g} at (16,8) size 359x156 [transform={m=((1.00,0.00)(0.00,1.00)) t=(70.00,-60.00)}]
RenderSVGText {text} at (30,130) size 343x25 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 343x25
Expand All @@ -19,18 +19,15 @@ layer at (0,0) size 480x360
RenderSVGText {text} at (10,208) size 239x15 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 239x15
chunk 1 text run 1 at (10.00,220.00) startOffset 0 endOffset 44 width 238.81: ".getCTM(): 0.42,0.42,-0.42,0.42,70.00,-60.00"
RenderSVGText {text} at (10,228) size 309x15 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 309x15
chunk 1 text run 1 at (10.00,240.00) startOffset 0 endOffset 56 width 308.17: ".getTransformToElement(): 0.42,0.42,-0.42,0.42,0.00,0.00"
RenderSVGText {text} at (10,248) size 336x15 contains 1 chunk(s)
RenderSVGText {text} at (10,228) size 336x15 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 336x15
chunk 1 text run 1 at (10.00,260.00) startOffset 0 endOffset 64 width 335.43: ".getBBox() for 'redCircle': .x=-50,.y=-50,.width=100,.height=100"
RenderSVGText {text} at (10,268) size 250x15 contains 1 chunk(s)
chunk 1 text run 1 at (10.00,240.00) startOffset 0 endOffset 64 width 335.43: ".getBBox() for 'redCircle': .x=-50,.y=-50,.width=100,.height=100"
RenderSVGText {text} at (10,248) size 250x15 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 250x15
chunk 1 text run 1 at (10.00,280.00) startOffset 0 endOffset 46 width 249.11: ".farthestViewportElement of redCircle=svg-root"
RenderSVGText {text} at (10,288) size 268x15 contains 1 chunk(s)
chunk 1 text run 1 at (10.00,260.00) startOffset 0 endOffset 46 width 249.11: ".farthestViewportElement of redCircle=svg-root"
RenderSVGText {text} at (10,268) size 268x15 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 268x15
chunk 1 text run 1 at (10.00,300.00) startOffset 0 endOffset 46 width 267.13: ".nearestViewportElement of redCircle=nestedSVG"
chunk 1 text run 1 at (10.00,280.00) startOffset 0 endOffset 46 width 267.13: ".nearestViewportElement of redCircle=nestedSVG"
RenderSVGText {text} at (10,304) size 264x45 contains 1 chunk(s)
RenderSVGInlineText {#text} at (0,0) size 264x45
chunk 1 text run 1 at (10.00,340.00) startOffset 0 endOffset 16 width 263.34: "$Revision: 1.1 $"
Expand Down
11 changes: 0 additions & 11 deletions LayoutTests/platform/ios/svg/custom/getTransformToElement-expected.txt
View file

This file was deleted.

16 changes: 0 additions & 16 deletions LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/getTransformToElement-expected.txt
View file

This file was deleted.

Binary file removed ...sts/platform/mac-sonoma-wk2-pixel/svg/custom/getTransformToElement-expected.png
View file
Binary file not shown.

0 comments on commit f1cd15a

Please sign in to comment.