[view-transitions] Support :active-view-transition pseudo-class

https://bugs.webkit.org/show_bug.cgi?id=275488 rdar://129851076 Reviewed by Darin Adler. This is part of the level 2 spec: https://drafts.csswg.org/css-view-transitions-2/#the-active-view-transition-pseudo This matches anytime there is an active view transition on the document. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/active-view-transition-pseudo-class-match-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/view-transition-types-universal-match-expected.html. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/active-view-transition-pseudo-class-match.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/view-transition-types-universal-match.html. * Source/WebCore/css/CSSPseudoSelectors.json: * Source/WebCore/css/SelectorChecker.cpp: (WebCore::SelectorChecker::checkOne const): * Source/WebCore/css/SelectorCheckerTestFunctions.h: (WebCore::matchesActiveViewTransitionPseudoClass): * Source/WebCore/cssjit/SelectorCompiler.cpp: (WebCore::SelectorCompiler::JSC_DEFINE_NOEXCEPT_JIT_OPERATION): (WebCore::SelectorCompiler::addPseudoClassType): * Source/WebCore/dom/Document.cpp: (WebCore::Document::setActiveViewTransition): Canonical link: https://commits.webkit.org/280027@main
WebKit · Jun 14, 2024 · cd6cadf · cd6cadf
1 parent 5c367f9
commit cd6cadf
Show file tree

Hide file tree

Showing 8 changed files with 28 additions and 1 deletion.
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
@@ -6981,7 +6981,6 @@ imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-with-classes-vie
 imported/w3c/web-platform-tests/css/css-view-transitions/navigation [ Skip ]
 
 # View transitions Level 2 - types.
-imported/w3c/web-platform-tests/css/css-view-transitions/view-transition-types-universal-match.html [ ImageOnlyFailure ]
 imported/w3c/web-platform-tests/css/css-view-transitions/view-transition-types-match-early-mutation.html [ Skip ]
 imported/w3c/web-platform-tests/css/css-view-transitions/view-transition-types-match-early.html [ Skip ]
 imported/w3c/web-platform-tests/css/css-view-transitions/view-transition-types-match-late-mutation.html [ Skip ]

diff --git a/...ition-types-universal-match-expected.html → ...ansition-pseudo-class-match-expected.html b/...ition-types-universal-match-expected.html → ...ansition-pseudo-class-match-expected.html
diff --git a/...iew-transition-types-universal-match.html → ...e-view-transition-pseudo-class-match.html b/...iew-transition-types-universal-match.html → ...e-view-transition-pseudo-class-match.html
diff --git a/Source/WebCore/css/CSSPseudoSelectors.json b/Source/WebCore/css/CSSPseudoSelectors.json
@@ -72,6 +72,9 @@
             "status": "non-standard"
         },
         "active": {},
+        "active-view-transition": {
+            "settings-flag": "viewTransitionsEnabled"
+        },
         "any-link": {
             "aliases": [
                 "-webkit-any-link"

diff --git a/Source/WebCore/css/SelectorChecker.cpp b/Source/WebCore/css/SelectorChecker.cpp
@@ -1161,6 +1161,9 @@ bool SelectorChecker::checkOne(CheckingContext& checkingContext, const LocalCont
 
         case CSSSelector::PseudoClass::UserValid:
             return matchesUserValidPseudoClass(element);
+
+        case CSSSelector::PseudoClass::ActiveViewTransition:
+            return matchesActiveViewTransitionPseudoClass(element);
         }
         return false;
     }

diff --git a/Source/WebCore/css/SelectorCheckerTestFunctions.h b/Source/WebCore/css/SelectorCheckerTestFunctions.h
@@ -583,4 +583,11 @@ ALWAYS_INLINE bool matchesUserValidPseudoClass(const Element& element)
     return element.matchesUserValidPseudoClass();
 }
 
+ALWAYS_INLINE bool matchesActiveViewTransitionPseudoClass(const Element& element)
+{
+    if (&element != element.document().documentElement())
+        return false;
+    return !!element.document().activeViewTransition();
+}
+
 } // namespace WebCore
diff --git a/Source/WebCore/cssjit/SelectorCompiler.cpp b/Source/WebCore/cssjit/SelectorCompiler.cpp
@@ -128,6 +128,7 @@ using PseudoClassesSet = HashSet<CSSSelector::PseudoClass, IntHash<CSSSelector::
     v(operationMatchesPopoverOpenPseudoClass) \
     v(operationMatchesModalPseudoClass) \
     v(operationMatchesHtmlDocumentPseudoClass) \
+    v(operationMatchesActiveViewTransitionPseudoClass) \
     v(operationIsUserInvalid) \
     v(operationIsUserValid) \
     v(operationAddStyleRelationFunction) \
@@ -281,6 +282,7 @@ static JSC_DECLARE_NOEXCEPT_JIT_OPERATION_WITHOUT_WTF_INTERNAL(operationHasAttac
 static JSC_DECLARE_NOEXCEPT_JIT_OPERATION_WITHOUT_WTF_INTERNAL(operationMatchesHtmlDocumentPseudoClass, bool, (const Element&));
 static JSC_DECLARE_NOEXCEPT_JIT_OPERATION_WITHOUT_WTF_INTERNAL(operationMatchesPopoverOpenPseudoClass, bool, (const Element&));
 static JSC_DECLARE_NOEXCEPT_JIT_OPERATION_WITHOUT_WTF_INTERNAL(operationMatchesModalPseudoClass, bool, (const Element&));
+static JSC_DECLARE_NOEXCEPT_JIT_OPERATION_WITHOUT_WTF_INTERNAL(operationMatchesActiveViewTransitionPseudoClass, bool, (const Element&));
 static JSC_DECLARE_NOEXCEPT_JIT_OPERATION_WITHOUT_WTF_INTERNAL(operationIsUserInvalid, bool, (const Element&));
 static JSC_DECLARE_NOEXCEPT_JIT_OPERATION_WITHOUT_WTF_INTERNAL(operationIsUserValid, bool, (const Element&));
 
@@ -1024,6 +1026,12 @@ JSC_DEFINE_NOEXCEPT_JIT_OPERATION(operationMatchesModalPseudoClass, bool, (const
     return matchesModalPseudoClass(element);
 }
 
+JSC_DEFINE_NOEXCEPT_JIT_OPERATION(operationMatchesActiveViewTransitionPseudoClass, bool, (const Element& element))
+{
+    COUNT_SELECTOR_OPERATION(operationMatchesActiveViewTransitionPseudoClass);
+    return matchesActiveViewTransitionPseudoClass(element);
+}
+
 JSC_DEFINE_NOEXCEPT_JIT_OPERATION(operationIsUserInvalid, bool, (const Element& element))
 {
     COUNT_SELECTOR_OPERATION(operationIsUserInvalid);
@@ -1191,6 +1199,10 @@ static inline FunctionType addPseudoClassType(const CSSSelector& selector, Selec
         fragment.unoptimizedPseudoClasses.append(CodePtr<JSC::OperationPtrTag>(operationIsUserValid));
         return FunctionType::SimpleSelectorChecker;
 
+    case CSSSelector::PseudoClass::ActiveViewTransition:
+        fragment.unoptimizedPseudoClasses.append(CodePtr<JSC::OperationPtrTag>(operationMatchesActiveViewTransitionPseudoClass));
+        return FunctionType::SimpleSelectorChecker;
+
     // These pseudo-classes only have meaning with scrollbars.
     case CSSSelector::PseudoClass::Horizontal:
     case CSSSelector::PseudoClass::Vertical:

diff --git a/Source/WebCore/dom/Document.cpp b/Source/WebCore/dom/Document.cpp
@@ -10582,6 +10582,9 @@ bool Document::activeViewTransitionCapturedDocumentElement() const
 
 void Document::setActiveViewTransition(RefPtr<ViewTransition>&& viewTransition)
 {
+    std::optional<Style::PseudoClassChangeInvalidation> styleInvalidation;
+    if (documentElement())
+        styleInvalidation.emplace(*documentElement(), CSSSelector::PseudoClass::ActiveViewTransition, !!viewTransition);
     m_activeViewTransition = WTFMove(viewTransition);
 }