-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
AX Web Inspector Panel: Switch form controls report "Checked: true/fa…
…lse" rather than something like "State: on/off" https://bugs.webkit.org/show_bug.cgi?id=274846 rdar://128952449 Reviewed by Devin Rousso. Switches are like checkboxes without a mixed state, and are exposed in the web platform in this way — HTML switches are created via `input type="checkbox"` plus the `switch` attribute, and are "enabled" via the `checked` attribute. And ARIA switches (`role="switch"`) use `aria-checked`. A side effect of this is that when we added support for switch controls, we forgot to update Web Inspector to handle the nuanced difference between these types of controls, and thus switch controls report a "Checked: true/false" state rather than "State: on/off", which is more appropriate terminology. This patch addresses this issue. * LayoutTests/inspector/dom/getAccessibilityPropertiesForNode-expected.txt: * LayoutTests/inspector/dom/getAccessibilityPropertiesForNode.html: * Source/JavaScriptCore/inspector/protocol/DOM.json: * Source/WebCore/inspector/agents/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties): * Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js: * Source/WebInspectorUI/UserInterface/Models/DOMNode.js: (WI.DOMNode.prototype.accessibilityProperties.accessibilityPropertiesCallback): (WI.DOMNode.prototype.accessibilityProperties): * Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js: (WI.DOMNodeDetailsSidebarPanel.prototype.initialLayout): (WI.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility.accessibilityPropertiesCallback): (WI.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility): Canonical link: https://commits.webkit.org/279772@main
- Loading branch information
Showing
7 changed files
with
84 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters