Page MenuHomePhabricator

Bug 1682030 - Remove nsIPluginWidget r=jmathies!
ClosedPublic

Authored by handyman on Mar 4 2021, 12:21 AM.

Details

Summary

Removes unused nsIPluginWidget, as part of removing all NPAPI support.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.

Code analysis found 10 defects in the diff 407996:

  • 10 build errors found by clang-tidy

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

You have touched the documentation in diff 407996, you can find it rendered here for a week.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

handyman retitled this revision from Bug 1682030 - Remove nsIPluginWidget DONTBUILD r=jmathies! to Bug 1682030 - Remove nsIPluginWidget r=jmathies!.Mar 4 2021, 6:29 PM
This revision is now accepted and ready to land.Mar 12 2021, 6:02 PM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other.

handyman edited the summary of this revision. (Show Details)

Code analysis found 10 defects in the diff 414002:

  • 10 build errors found by clang-tidy

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

You have touched the documentation in diff 414002, you can find it rendered here for a week.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 8 defects in the diff 421883:

  • 2 defects found by private static analysis
  • 6 build errors found by clang-tidy

You can run this analysis locally with:

  • For private static analysis, please see our private docs in Mana, if you cannot access this resource, ask your reviewer to help you resolve the issue.
  • ./mach static-analysis check --outgoing (C/C++)

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

You have touched the documentation in diff 421883, you can find it rendered here for a week.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 8 defects in the diff 422353:

  • 2 defects found by private static analysis
  • 6 build errors found by clang-tidy

You can run this analysis locally with:

  • For private static analysis, please see our private docs in Mana, if you cannot access this resource, ask your reviewer to help you resolve the issue.
  • ./mach static-analysis check --outgoing (C/C++)

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

You have touched the documentation in diff 422353, you can find it rendered here for a week.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

This revision is now accepted and ready to land.Apr 6 2021, 12:59 AM

Code analysis found 8 defects in the diff 423034:

  • 2 defects found by private static analysis
  • 6 build errors found by clang-tidy

You can run this analysis locally with:

  • For private static analysis, please see our private docs in Mana, if you cannot access this resource, ask your reviewer to help you resolve the issue.
  • ./mach static-analysis check --outgoing (C/C++)

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

You have touched the documentation in diff 423034, you can find it rendered here for a week.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.