Page MenuHomePhabricator

Bug 1682030 - Remove NPAPI support from ClearDataService. r=baku!
ClosedPublic

Authored by handyman on Mar 4 2021, 12:20 AM.
Referenced Files
Unknown Object (File)
Jan 14 2024, 3:01 AM
Unknown Object (File)
Jan 3 2024, 4:48 PM
Unknown Object (File)
Apr 5 2023, 8:05 AM
Subscribers

Details

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Lint Not Applicable
Unit
Tests Not Applicable
Build Status
Buildable 308087
Build 401738: arc lint + arc unit

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.

Code analysis found 10 defects in the diff 407993:

  • 10 build errors found by clang-tidy

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

This revision is now accepted and ready to land.Mar 4 2021, 5:31 PM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other.

handyman retitled this revision from Bug 1682030 - Remove NPAPI support from ClearDataService. DONTBUILD r=baku! to Bug 1682030 - Remove NPAPI support from ClearDataService. r=baku!.Mar 4 2021, 6:28 PM
handyman retitled this revision from Bug 1682030 - Remove NPAPI support from ClearDataService. r=baku! to Bug 1682030 - Remove NPAPI support from ClearDataService. r=baku!.
handyman edited the summary of this revision. (Show Details)

Code analysis found 10 defects in the diff 413999:

  • 10 build errors found by clang-tidy

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 8 defects in the diff 421880:

  • 2 defects found by private static analysis
  • 6 build errors found by clang-tidy

You can run this analysis locally with:

  • For private static analysis, please see our private docs in Mana, if you cannot access this resource, ask your reviewer to help you resolve the issue.
  • ./mach static-analysis check --outgoing (C/C++)

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 8 defects in the diff 422350:

  • 2 defects found by private static analysis
  • 6 build errors found by clang-tidy

You can run this analysis locally with:

  • For private static analysis, please see our private docs in Mana, if you cannot access this resource, ask your reviewer to help you resolve the issue.
  • ./mach static-analysis check --outgoing (C/C++)

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

This revision is now accepted and ready to land.Apr 6 2021, 12:59 AM

Code analysis found 8 defects in the diff 422919:

  • 2 defects found by private static analysis
  • 6 build errors found by clang-tidy

You can run this analysis locally with:

  • For private static analysis, please see our private docs in Mana, if you cannot access this resource, ask your reviewer to help you resolve the issue.
  • ./mach static-analysis check --outgoing (C/C++)

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 8 defects in the diff 423031:

  • 2 defects found by private static analysis
  • 6 build errors found by clang-tidy

You can run this analysis locally with:

  • For private static analysis, please see our private docs in Mana, if you cannot access this resource, ask your reviewer to help you resolve the issue.
  • ./mach static-analysis check --outgoing (C/C++)

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.