Details

Reviewers

Commits

rMOZILLACENTRAL080aa7b074c3: Bug 1682030 - Remove NPAPI from dom/plugins tests. r=jmathies
rMOZILLACENTRALa9cdf93c2662: Bug 1682030 - Remove NPAPI from dom/plugins tests. r=jmathies

Bugzilla Bug ID

1682030

Summary

Removes NPAPI plugin tests in dom/plugins, as well as the TestPlugin, as part of removing all of NPAPI plugin support. A small handful of tests that are still relevant remain in that directory.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

handyman created this revision.Mar 4 2021, 12:14 AM

Herald added a project: secure-revision. · View Herald TranscriptMar 4 2021, 12:14 AM

Harbormaster completed remote builds in B295257: Diff 407984.Mar 4 2021, 12:14 AM

phab-bot published this revision for review.Mar 4 2021, 12:15 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a subscriber: Standard8. · View Herald TranscriptMar 4 2021, 12:15 AM

handyman added a child revision: D107140: Bug 1682030 - Remove PPluginSurface. r=jmathies!,bas!.Mar 4 2021, 12:15 AM

Code analysis found 4 defects in the diff 407984:

4 defects found by code coverage analysis

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

handyman retitled this revision from Bug 1682030 - Remove NPAPI from dom/plugins tests. DONTBUILD r=jmathies! to Bug 1682030 - Remove NPAPI from dom/plugins tests. r=jmathies!.Mar 4 2021, 6:27 PM

jmathies accepted this revision.Mar 12 2021, 6:02 PM

This revision is now accepted and ready to land.Mar 12 2021, 6:02 PM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other.

handyman updated this revision to Diff 413987.Mar 16 2021, 8:22 PM

handyman retitled this revision from Bug 1682030 - Remove NPAPI from dom/plugins tests. r=jmathies! to Bug 1682030 - Remove NPAPI from dom/plugins tests. r=jmathies!.

handyman edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B300366: Diff 413987.Mar 16 2021, 8:22 PM

Code analysis found 4 defects in the diff 413987:

4 defects found by code coverage analysis

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

handyman updated this revision to Diff 421871.Apr 2 2021, 8:13 PM

Harbormaster completed remote builds in B306875: Diff 421871.Apr 2 2021, 8:13 PM

Code analysis found 4 defects in the diff 421871:

4 defects found by code coverage analysis

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

handyman updated this revision to Diff 422341.Apr 5 2021, 8:57 PM

Harbormaster completed remote builds in B307269: Diff 422341.Apr 5 2021, 8:57 PM

Code analysis found 4 defects in the diff 422341:

4 defects found by code coverage analysis

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

handyman updated this revision to Diff 422382.Apr 5 2021, 9:41 PM

Harbormaster completed remote builds in B307304: Diff 422382.Apr 5 2021, 9:41 PM

Closed by commit rMOZILLACENTRALa9cdf93c2662: Bug 1682030 - Remove NPAPI from dom/plugins tests. r=jmathies (authored by David Parks <daparks@mozilla.com>). · Explain WhyApr 5 2021, 11:55 PM

This revision was automatically updated to reflect the committed changes.

David Parks <daparks@mozilla.com> added a commit: rMOZILLACENTRALa9cdf93c2662: Bug 1682030 - Remove NPAPI from dom/plugins tests. r=jmathies.

• nataliaCs reopened this revision.Apr 6 2021, 12:59 AM

This revision is now accepted and ready to land.Apr 6 2021, 12:59 AM

• nataliaCs added a reverting change: rMOZILLACENTRALbd702683bc3c: Backed out 24 changesets (bug 1682030) for bustage on ProcessHangMonitor.cpp….Apr 6 2021, 12:59 AM

handyman updated this revision to Diff 422912.Apr 6 2021, 5:35 PM

Harbormaster completed remote builds in B307744: Diff 422912.Apr 6 2021, 5:35 PM

Code analysis found 4 defects in the diff 422912:

4 defects found by code coverage analysis

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

handyman updated this revision to Diff 423020.Apr 6 2021, 7:13 PM

Harbormaster completed remote builds in B307810: Diff 423020.Apr 6 2021, 7:13 PM

Code analysis found 4 defects in the diff 423020:

4 defects found by code coverage analysis

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Closed by commit rMOZILLACENTRAL080aa7b074c3: Bug 1682030 - Remove NPAPI from dom/plugins tests. r=jmathies (authored by David Parks <daparks@mozilla.com>). · Explain WhyApr 6 2021, 7:35 PM

This revision was automatically updated to reflect the committed changes.

David Parks <daparks@mozilla.com> added a commit: rMOZILLACENTRAL080aa7b074c3: Bug 1682030 - Remove NPAPI from dom/plugins tests. r=jmathies.

Bug 1682030 - Remove NPAPI from dom/plugins tests. r=jmathies!ClosedPublicActions

Details

Diff Detail

Event Timeline

Large Diff

Revision ContentsChangeset List

Diff 423059

dom/plugins/test/crashtests/539897-1.html

dom/plugins/test/crashtests/540114-1.html

dom/plugins/test/crashtests/570884.html

dom/plugins/test/crashtests/598862.html

dom/plugins/test/crashtests/626602-1.html

dom/plugins/test/crashtests/crashtests.list

dom/plugins/test/mochitest/.eslintrc.js

dom/plugins/test/mochitest/307-xo-redirect.sjs

dom/plugins/test/mochitest/browser.ini

dom/plugins/test/mochitest/browser_bug1163570.js

dom/plugins/test/mochitest/browser_pluginscroll.js

dom/plugins/test/mochitest/browser_tabswitchbetweenplugins.js

dom/plugins/test/mochitest/file_authident.js

dom/plugins/test/mochitest/file_bug771202.html

dom/plugins/test/mochitest/file_bug863792.html

dom/plugins/test/mochitest/head.js

dom/plugins/test/mochitest/loremipsum.txt

dom/plugins/test/mochitest/loremipsum.xtest

dom/plugins/test/mochitest/loremipsum.xtest^headers^

dom/plugins/test/mochitest/loremipsum_file.txt

dom/plugins/test/mochitest/loremipsum_nocache.txt

dom/plugins/test/mochitest/loremipsum_nocache.txt^headers^

dom/plugins/test/mochitest/mochitest.ini

dom/plugins/test/mochitest/neverending.sjs

dom/plugins/test/mochitest/npruntime_identifiers_subpage.html

dom/plugins/test/mochitest/plugin-stream-referer.sjs

dom/plugins/test/mochitest/plugin-utils.js

dom/plugins/test/mochitest/plugin_no_scroll_div.html

dom/plugins/test/mochitest/plugin_subframe_test.html

dom/plugins/test/mochitest/plugin_test.html

dom/plugins/test/mochitest/plugin_window.html

dom/plugins/test/mochitest/pluginstream.js

dom/plugins/test/mochitest/post.sjs

dom/plugins/test/mochitest/test_hanging.html

dom/plugins/test/mochitest/test_plugin_scroll_invalidation.html

dom/plugins/test/mochitest/test_plugin_scroll_painting.html

dom/plugins/test/mochitest/test_pluginstream_geturl.html

dom/plugins/test/mochitest/test_pluginstream_geturlnotify.html

dom/plugins/test/mochitest/test_positioning.html

dom/plugins/test/mochitest/test_queryContentsScaleFactor.html

dom/plugins/test/mochitest/test_queryContentsScaleFactorWindowed.html

dom/plugins/test/mochitest/test_refresh_navigator_plugins.html

dom/plugins/test/moz.build

dom/plugins/test/reftest/border-padding-1-ref.html

dom/plugins/test/reftest/border-padding-1.html

dom/plugins/test/reftest/border-padding-2-ref.html

dom/plugins/test/reftest/border-padding-2.html

dom/plugins/test/reftest/border-padding-3-ref.html

dom/plugins/test/reftest/border-padding-3.html

dom/plugins/test/reftest/div-alpha-opacity.html

dom/plugins/test/reftest/div-alpha-zindex.html

dom/plugins/test/reftest/div-sanity.html

dom/plugins/test/reftest/plugin-alpha-opacity.html

dom/plugins/test/reftest/plugin-alpha-zindex.html

dom/plugins/test/reftest/plugin-background-1-step.html

dom/plugins/test/reftest/plugin-background-10-step.html

dom/plugins/test/reftest/plugin-background-2-step.html

dom/plugins/test/reftest/plugin-background-5-step.html

dom/plugins/test/reftest/plugin-background-ref.html

dom/plugins/test/reftest/plugin-background.html

dom/plugins/test/reftest/plugin-background.css

dom/plugins/test/reftest/plugin-background.js

dom/plugins/test/reftest/plugin-busy-alpha-zindex.html

dom/plugins/test/reftest/plugin-canvas-alpha-zindex.html

dom/plugins/test/reftest/plugin-sanity.html

dom/plugins/test/reftest/plugin-transform-1-ref.html

dom/plugins/test/reftest/plugin-transform-1.html

dom/plugins/test/reftest/plugin-transform-2-ref.html

dom/plugins/test/reftest/plugin-transform-2.html

dom/plugins/test/reftest/plugin-transform-alpha-zindex.html

dom/plugins/test/reftest/reftest.list

dom/plugins/test/reftest/shrink-1-ref.html

dom/plugins/test/reftest/shrink-1.html

Bug 1682030 - Remove NPAPI from dom/plugins tests. r=jmathies!
ClosedPublic
Actions

Revision Contents
Changeset List