Page MenuHomePhabricator

Bug 1682030 - Fix mac build wrt plugin_child_interpose
AbandonedPublicDraft

Authored by handyman on Dec 11 2020, 7:44 PM.

Details

Reviewers
None
Bugzilla Bug ID
1682030

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Branch
default
Lint
No Lint Coverage
SeverityLocationCodeMessage
Errordom/plugins/base/nsNPAPIPluginInstance.cpp:289clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsNPAPIPluginInstance.cpp:294clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsNPAPIPluginInstance.h:83clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsNPAPIPluginInstance.h:113clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsNPAPIPluginInstance.h:114clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginHost.cpp:26clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.cpp:824clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.cpp:843clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.cpp:2280clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.cpp:2289clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.cpp:2290clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.cpp:2579clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.cpp:2588clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.cpp:2589clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.cpp:2591clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.cpp:2598clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.cpp:2882clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.cpp:2893clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.h:122clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.h:220clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.h:248clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.h:292clang-diagnostic-errorBuild Error
Errormfbt/RefPtr.h:49clang-diagnostic-errorBuild Error
Errormfbt/RefPtr.h:50clang-diagnostic-errorBuild Error
Errortoolkit/xre/nsEmbedFunctions.cpp:528clang-diagnostic-errorBuild Error
Unit
No Test Coverage

Event Timeline

handyman created this revision.
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Dec 11 2020, 7:45 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.

Code analysis found 95 defects in the diff 378023:

  • 95 build errors found by clang-tidy

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

handyman edited the summary of this revision. (Show Details)

Code analysis found 95 defects in the diff 378159:

  • 95 build errors found by clang-tidy

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.