Bug 279636 - Remove Quirk isStorageAccessQuirkDomainAndElement for gizmodo.com
Summary: Remove Quirk isStorageAccessQuirkDomainAndElement for gizmodo.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Karl Dubost
URL: http://gizmodo.com/
Keywords: InRadar
Depends on: 266442
Blocks:
  Show dependency treegraph
 
Reported: 2024-09-12 18:23 PDT by Karl Dubost
Modified: 2024-09-12 23:30 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Dubost 2024-09-12 18:23:08 PDT
On Bug 266442 / rdar://106782128, gizmodo.com has been added to isStorageAccessQuirkDomainAndElement

The issue was describe as

Steps To Reproduce:
1. Navigate to Gizmodo.com
2. Tap on profile icon on top right of page 
3. Tap “connect with Google” 
4. New tab will open up, and then close without authenticating google login. 



Results:
Unable to login with google credentials 

Expected result: Able to login to gizmodo.com using google credentials


Gizmodo recently went out of the Kinja Login network. 
They do not have any login facility anymore. 
And this is not part of https://g-omedia.com/brands/ anymore.

They have a login system which is now powered by https://www.openweb.com/powered-by/
and is accessible only under the articles themselves and which also makes it possible to comment as a guest. 


I think we can remove this quirk.
Comment 1 Karl Dubost 2024-09-12 18:37:58 PDT
So I tested with Quirks disabled and the login system for comments is working. 
So the QUirk is not needed anymore. 
I will be waiting for the bug importer to come back live to have a proper radar for the PR.
Comment 2 Radar WebKit Bug Importer 2024-09-12 20:15:05 PDT
<rdar://problem/135927150>
Comment 3 Karl Dubost 2024-09-12 20:23:31 PDT
Pull request: https://github.com/WebKit/WebKit/pull/33591
Comment 4 EWS 2024-09-12 23:30:15 PDT
Committed 283600@main (c0f0e06eae05): <https://commits.webkit.org/283600@main>

Reviewed commits have been landed. Closing PR #33591 and removing active labels.