Bug 279558 - Deploy more smart pointers in NetworkStorageManager.cpp
Summary: Deploy more smart pointers in NetworkStorageManager.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Website Storage (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on: 279619
Blocks:
  Show dependency tree / graph
 
Reported: 2024-09-11 17:27 PDT by Ryosuke Niwa
Modified: 2024-09-12 22:54 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2024-09-11 17:27:48 PDT 
Deploy more smart pointers in NetworkStorageManager.cpp as warned by the clang static analyzer.
Comment 1 Ryosuke Niwa 2024-09-11 17:30:21 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/33508
Comment 2 EWS 2024-09-11 18:37:12 PDT 
Committed 283521@main (574833340948): <https://commits.webkit.org/283521@main>

Reviewed commits have been landed. Closing PR #33508 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2024-09-11 18:38:15 PDT 
<rdar://problem/135841490>
Comment 4 Marta Darbinyan 2024-09-12 14:47:24 PDT 
Reopened Bugzilla.
REGRESSION(283521@main): [MacOS wk2 Debug EWS] storage limit and cache-storage tests are crashing with ASSERTION FAILED: m_thread.ptr() == &Thread::current(), tracking revert in https://bugs.webkit.org/show_bug.cgi?id=279619.
Comment 5 Ryosuke Niwa 2024-09-12 18:43:08 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/33589
Comment 6 EWS 2024-09-12 22:54:17 PDT 
Committed 283598@main (513e79a88e64): <https://commits.webkit.org/283598@main>

Reviewed commits have been landed. Closing PR #33589 and removing active labels.