fix: correct unique constraints and field when org remove event is created #9211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks for your contribution @stebenz! 🎉Please make sure you tick the following checkboxes before marking this Pull Request (PR) as ready for review:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9211 +/- ##
==========================================
+ Coverage 62.50% 62.51% +0.01%
==========================================
Files 1597 1598 +1
Lines 149401 149437 +36
==========================================
+ Hits 93382 93421 +39
+ Misses 51428 51427 -1
+ Partials 4591 4589 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Problems Are Solved
In a specific situation of a name change of the organization, the unique constraint is still existing even though the org domain is removed, and the fields get only set to org domain not verified and not removed.
How the Problems Are Solved
Remove unique constraints which should not exist anymore.
Remove field which should not exist anymore.
Fix logic for OrgDomainRemoved event, so that fields are removed in the future.
Additional Changes
None
Additional Context
None