feat(\internal): sorting column on ListIAMMembersRequest #9203
+57
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hifabienne
added
the
os-contribution
MAHANTH-wq
changed the title
MAHANTH-wq
changed the title
MAHANTH-wq
commented
Jan 17, 2025
MAHANTH-wq
commented
Jan 17, 2025
| @@ -143,3 +143,11 @@ message UserIDQuery { | |||
| } | |||
| ]; | |||
| } | |||
|
|
|||
| enum MemberFieldColumnName { | |||
There was a problem hiding this comment.
Please comment on what fields to be considered here, for now i have added these fields
There was a problem hiding this comment.
That's alright, additional fields can be added later on if necessary.
stebenz
reviewed
Jan 27, 2025
| @@ -8776,8 +8776,9 @@ message ListIAMMemberRolesResponse { | |||
| message ListIAMMembersRequest { | |||
| //list limitations and ordering | |||
| zitadel.v1.ListQuery query = 1; | |||
| zitadel.member.v1.MemberFieldColumnName sorting_column=2; | |||
There was a problem hiding this comment.
Please fix formatting and use '3' for this field, to not break the already existing definition.
| @@ -143,3 +143,11 @@ message UserIDQuery { | |||
| } | |||
| ]; | |||
| } | |||
|
|
|||
| enum MemberFieldColumnName { | |||
There was a problem hiding this comment.
That's alright, additional fields can be added later on if necessary.
| @@ -688,7 +688,8 @@ message RemoveInstanceResponse { | |||
| message ListIAMMembersRequest { | |||
| zitadel.v1.ListQuery query = 1; | |||
| string instance_id = 2; | |||
| repeated zitadel.member.v1.SearchQuery queries = 3; | |||
| zitadel.member.v1.MemberFieldColumnName sorting_column=3; | |||
There was a problem hiding this comment.
Please fix formatting and use '4' for this field, to not break the already existing definition.
|
@MAHANTH-wq Please also fill in the PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Problems Are Solved
Replace this example text with a concise list of problems that this PR solves.
For example:
How the Problems Are Solved
Replace this example text with a concise list of changes that this PR introduces.
For example:
Additional Changes
Replace this example text with a concise list of additional changes that this PR introduces, that are not directly solving the initial problem but are related.
For example:
Additional Context
Replace this example with links to related issues, discussions, discord threads, or other sources with more context.
Use the Closing #issue syntax for issues that are resolved with this PR.