Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python 3.13 to build sdist during CI #2671

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

swt2c
Copy link
Collaborator

@swt2c swt2c commented Jan 14, 2025

Fixes: #2670

@echoix
Copy link

echoix commented Jan 14, 2025

Ah great! I would've done the PR too if it was agreed upon

.github/workflows/ci-build.yml Outdated Show resolved Hide resolved
@echoix
Copy link

echoix commented Jan 14, 2025

Was there any other reason why some steps, or jobs, aren't always run in CI? There doesn't seem to be that much of PRs happening, and not checking if things regress when they could sounds strange to me. I understand that the steps that publish or upload to a server shouldn't be done, but like making sure that the demo (that is shipped) still builds sounds like it has some value

@swt2c
Copy link
Collaborator Author

swt2c commented Jan 14, 2025

Was there any other reason why some steps, or jobs, aren't always run in CI? There doesn't seem to be that much of PRs happening, and not checking if things regress when they could sounds strange to me. I understand that the steps that publish or upload to a server shouldn't be done, but like making sure that the demo (that is shipped) still builds sounds like it has some value

As far as not building the demo during PR's, probably mainly because it's not too likely to break given that it's mostly just making a tarball of the demo files. Probably couldn't hurt to do it either, though, as it probably doesn't take much time.

What I would really like is for us to run the unittests during PRs. That would be very useful, I think. The last time I tried that, I ran into problems though, that I never sorted out.

@swt2c swt2c merged commit 385bc6a into wxWidgets:master Jan 14, 2025
25 checks passed
@swt2c swt2c deleted the ci_sdist_py313 branch January 14, 2025 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve sdist build time in CI
2 participants