Skip to content

Commit

Permalink
Cookstyle 7.5.3 Fixes
Browse files Browse the repository at this point in the history
Issues found and resolved with: attributes/default.rb

 - 3:1 refactor: Chef/Style/CommentFormat - Properly format header comments
 - 6:1 refactor: Chef/Style/CommentFormat - Properly format header comments

Issues found and resolved with: metadata.rb

 - 6:1 refactor: Chef/Modernize/RespondToInMetadata - It is no longer necessary to use respond_to? or defined? in metadata.rb in Chef Infra Client 12.15 and later
 - 9:1 refactor: Chef/RedundantCode/LongDescriptionMetadata - The long_description metadata.rb method is not used and is unnecessary in cookbooks.

Issues found and resolved with: recipes/default.rb

 - 3:1 refactor: Chef/Style/CommentFormat - Properly format header comments
 - 6:1 refactor: Chef/Style/CommentFormat - Properly format header comments

Signed-off-by: Xorima Bot <xorimabot@avon-lea.co.uk>
xorimabot committed Jan 8, 2021
1 parent 2f46382 commit 52e0386
Showing 4 changed files with 14 additions and 6 deletions.
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -2,6 +2,15 @@

This file is used to list changes made in each version of notepadpp.

## Unreleased

- resolved cookstyle error: attributes/default.rb:3:1 refactor: `Chef/Style/CommentFormat`
- resolved cookstyle error: attributes/default.rb:6:1 refactor: `Chef/Style/CommentFormat`
- resolved cookstyle error: metadata.rb:6:1 refactor: `Chef/Modernize/RespondToInMetadata`
- resolved cookstyle error: metadata.rb:9:1 refactor: `Chef/RedundantCode/LongDescriptionMetadata`
- resolved cookstyle error: recipes/default.rb:3:1 refactor: `Chef/Style/CommentFormat`
- resolved cookstyle error: recipes/default.rb:6:1 refactor: `Chef/Style/CommentFormat`

## 2.0.0

* Support Chef 13, drop support for Chef 12.
4 changes: 2 additions & 2 deletions attributes/default.rb
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
#
# Author:: Shawn Neal (<sneal@sneal.net>)
# Cookbook Name:: notepadpp
# Cookbook:: notepadpp
# Attribute:: default
#
# Copyright 2016, Shawn Neal
# Copyright:: 2016, Shawn Neal
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
3 changes: 1 addition & 2 deletions metadata.rb
Original file line number Diff line number Diff line change
@@ -3,10 +3,9 @@
maintainer_email 'sneal@sneal.net'
source_url 'https://github.com/windowschefcookbooks/notepadpp'
issues_url 'https://github.com/windowschefcookbooks/notepadpp/issues'
chef_version '>= 13.0' if respond_to?(:chef_version)
chef_version '>= 13.0'
license 'Apache-2.0'
description 'Installs/Configures Notepad++'
long_description IO.read(File.join(File.dirname(__FILE__), 'README.md'))
version '2.0.0'
supports 'windows'
depends 'windows'
4 changes: 2 additions & 2 deletions recipes/default.rb
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
#
# Author:: Shawn Neal (<sneal@sneal.net>)
# Cookbook Name:: notepadpp
# Cookbook:: notepadpp
# Attribute:: default
#
# Copyright 2016, Shawn Neal
# Copyright:: 2016, Shawn Neal
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.

0 comments on commit 52e0386

Please sign in to comment.