Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add channels param to files.upload v2 method (and its underlying files.completeUploadExternal) #1427

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Add channels param to files.upload v2 method (and its underlying files.completeUploadExternal) #1427

merged 1 commit into from
Jan 28, 2025

Conversation

seratch
Copy link
Member

@seratch seratch commented Jan 27, 2025

This pull request adds the channels parameter to files.completeUploadExternal API method and the wrapper v2 method.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client labels Jan 27, 2025
@seratch seratch added this to the 1.45.2 milestone Jan 27, 2025
@seratch seratch self-assigned this Jan 27, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.20%. Comparing base (c8d803a) to head (d7cff9d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...java/com/slack/api/methods/RequestFormBuilder.java 33.33% 1 Missing and 1 partial ⚠️
...om/slack/api/methods/impl/FilesUploadV2Helper.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1427      +/-   ##
============================================
- Coverage     73.21%   73.20%   -0.01%     
+ Complexity     4377     4376       -1     
============================================
  Files           474      474              
  Lines         14205    14208       +3     
  Branches       1437     1438       +1     
============================================
+ Hits          10400    10401       +1     
- Misses         2958     2959       +1     
- Partials        847      848       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch seratch merged commit 2094cf2 into slackapi:main Jan 28, 2025
5 of 6 checks passed
@seratch seratch deleted the files-upload-v2-channels branch January 28, 2025 01:13
@seratch seratch mentioned this pull request Jan 28, 2025
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliamBergamin WilliamBergamin WilliamBergamin approved these changes

Assignees

@seratch seratch

Labels
enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client
Projects
None yet
Milestone
1.45.2
Development

Successfully merging this pull request may close these issues.
2 participants
@seratch @WilliamBergamin