peadm::restore fails when puppet-db export times out #266
Open
Description
Describe the Bug
When restoring a backup made with peadm::backup
that includes a dump of pe-puppetdb
, the restore plan uses puppet-db export
to save more recent data. In even a modestly-sized installation this export fails consistently for me, causing the plan to fail.
Expected Behavior
I expected the restore plan to disregard the contents of PuppetDB on the target system and simply restore the pg_dump
dump made by peadm::backup
. If I remove the run_command
calls to puppet-db
then this works just as I expect.
Steps to Reproduce
- Make a backup with
peadm::backup::backup['puppetdb']
set totrue
. - Restore the backup onto a target with a working and running PuppetDB.
Environment
RHEL 7, XL with replica, two compilers, three agents.
Additional Context
I can see the benefit of exporting PDB, but I think it's undesirable for it to be necessarily tied to whether the plan restores the PDB database dump.